public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] i.MX6: mx6q_sabrelite: add SATA bindings
Date: Thu, 15 Mar 2012 10:58:49 +0100	[thread overview]
Message-ID: <4F61BD59.7020404@denx.de> (raw)
In-Reply-To: <AD13664F485EE54694E29A7F9D5BE1AF0F8064@039-SN2MPN1-022.039d.mgd.msft.net>

On 15/03/2012 10:34, Liu Hui-R64343 wrote:

> As the comments in the imximage.cfg,
> 
> # set the default clock gate to save power
> DATA 4 0x020c4068 0x00C03F3F
> DATA 4 0x020c406c 0x0030FC03
> DATA 4 0x020c4070 0x0FFFC000
> DATA 4 0x020c4074 0x3FF00000
> DATA 4 0x020c4078 0x00FFF300
> DATA 4 0x020c407c 0x0F0000C3
> DATA 4 0x020c4080 0x000003FF
> 
> This is my intention for the default setting to gate clock as much as possible in
> order to save power. This also means that when other periph added you need
> Turn on the clock explicitly.

Indeed, this is a good idea and respects U-boot principles: enable
something only when it is needed.

> So, my suggestion is:
> - don't change this imximage.cfg,
> - turn on the clock you need in the driver code,

Agree

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2012-03-15  9:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <http://lists.denx.de/pipermail/u-boot/2012-March/#119234>
2012-03-13 16:59 ` [U-Boot] [PATCH V2] i.MX6: mx6q_sabrelite: add SATA bindings Eric Nelson
2012-03-14 14:53   ` Dirk Behme
2012-03-15  8:28     ` Stefano Babic
2012-03-15  9:34       ` Liu Hui-R64343
2012-03-15  9:58         ` Stefano Babic [this message]
2012-03-24  7:09   ` Dirk Behme
2012-03-24  8:19     ` stefano babic
2012-03-24 21:01       ` Eric Nelson
2012-03-25 10:17         ` Stefano Babic
2012-03-25 15:33           ` Eric Nelson
2012-03-24 20:41     ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F61BD59.7020404@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox