From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 19 Mar 2012 17:22:32 +0100 Subject: [U-Boot] [PATCH] pmic_i2c: Return error in case of invalid pmic_i2c_tx_num In-Reply-To: <1331933529-7380-1-git-send-email-festevam@gmail.com> References: <1331933529-7380-1-git-send-email-festevam@gmail.com> Message-ID: <4F675D48.2070709@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16/03/2012 22:32, Fabio Estevam wrote: > Return error in case of invalid pmic_i2c_tx_num. > > Signed-off-by: Fabio Estevam > --- > drivers/misc/pmic_i2c.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/misc/pmic_i2c.c b/drivers/misc/pmic_i2c.c > index ad55d64..ebb124d 100644 > --- a/drivers/misc/pmic_i2c.c > +++ b/drivers/misc/pmic_i2c.c > @@ -47,6 +47,9 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val) > case 1: > buf[0] = val & 0xff; > break; > + default: > + printf("%s: invalid tx_num: %d", __func__, pmic_i2c_tx_num); > + return -1; > } > > if (i2c_write(pmic_i2c_addr, reg, 1, buf, pmic_i2c_tx_num)) > @@ -73,6 +76,9 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) > case 1: > ret_val = buf[0]; > break; > + default: > + printf("%s: invalid tx_num: %d", __func__, pmic_i2c_tx_num); > + return -1; > } > memcpy(val, &ret_val, sizeof(ret_val)); Acked-by: Stefano Babic Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================