public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx53ard: Initialize return code with error
Date: Tue, 20 Mar 2012 07:41:16 +0100	[thread overview]
Message-ID: <4F68268C.7030606@denx.de> (raw)
In-Reply-To: <1332200485-3647-1-git-send-email-festevam@gmail.com>

On 20/03/2012 00:41, Fabio Estevam wrote:
> The variable "rc" is the return of board_eth_init() function. Initialize
> it with an error code, so that this function can return an error when
> CONFIG_SMC911X is not set.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx53ard/mx53ard.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/board/freescale/mx53ard/mx53ard.c b/board/freescale/mx53ard/mx53ard.c
> index e90e39e..2d21584 100644
> --- a/board/freescale/mx53ard/mx53ard.c
> +++ b/board/freescale/mx53ard/mx53ard.c
> @@ -287,7 +287,7 @@ int board_init(void)
>  
>  int board_eth_init(bd_t *bis)
>  {
> -	int rc = 0;
> +	int rc = -ENODEV;
>  
>  	weim_smc911x_iomux();
>  	weim_cs1_settings();

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2012-03-20  6:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 23:41 [U-Boot] [PATCH] mx53ard: Initialize return code with error Fabio Estevam
2012-03-20  6:41 ` Stefano Babic [this message]
2012-03-23 10:37 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F68268C.7030606@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox