From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] Add board_panic_no_console() to deal with early critical errors
Date: Tue, 20 Mar 2012 18:34:56 -0600 [thread overview]
Message-ID: <4F692230.4010509@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ3GxEUXR6QiaeXxt6R5vT=MhAhgCyE70OjMoru4C_BkxQ@mail.gmail.com>
On 03/20/2012 05:22 PM, Simon Glass wrote:
> On Tue, Mar 20, 2012 at 3:26 PM, Graeme Russ <graeme.russ@gmail.com> wrote:
...
>> OK, so what about in panic():
>> - If gd->have_console is not set:
>> o call the board specific setup_panic_uarts()
>> o call print_pre_console_buffer() passing panic_putc()
>> o call panic_putc() for all characters in str[]
>> - If gd->have_console is set:
>> o call putc() for all characters in str[]
>>
>> setup_panic_uarts() and panic_putc() are overriden in the board files
>
> I think this is where we got to last time.
>
> The act of calling this pre-console panic function is destructive - it
> may hang the board and output data to UARTs.
Why would it hang? Well, I assume you're talking about hanging before
actually emitting the panic text, rather than looping afterwards as a
deliberate choice. I'd consider an accidental hang that prevented the
message being seen as a bug.
next prev parent reply other threads:[~2012-03-21 0:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 20:27 [U-Boot] [PATCH 1/5] Revert "Add board_pre_console_putc to deal with early console output" Simon Glass
2012-03-19 20:27 ` [U-Boot] [PATCH 2/5] Add board_panic_no_console() to deal with early critical errors Simon Glass
2012-03-20 22:26 ` Graeme Russ
2012-03-20 23:22 ` Simon Glass
2012-03-20 23:43 ` Graeme Russ
2012-03-21 0:06 ` Simon Glass
2012-03-21 0:34 ` Stephen Warren [this message]
2012-03-21 0:36 ` Simon Glass
2012-03-21 9:02 ` Wolfgang Denk
2012-03-21 16:17 ` Simon Glass
2012-03-21 22:48 ` Wolfgang Denk
2012-03-21 23:04 ` Wolfgang Denk
2012-03-19 20:27 ` [U-Boot] [PATCH 3/5] tegra: Export the UART setup function for use by boards Simon Glass
2012-03-21 9:04 ` Wolfgang Denk
2012-03-19 20:27 ` [U-Boot] [PATCH 4/5] tegra: Provide tegra_pre_console_panic() for early panics Simon Glass
2012-03-19 21:16 ` Stephen Warren
2012-03-19 22:55 ` Simon Glass
2012-03-19 20:27 ` [U-Boot] [PATCH 5/5] tegra: Implement board_pre_console_panic() for Seaboard Simon Glass
2012-03-19 21:18 ` Stephen Warren
2012-03-19 22:59 ` Simon Glass
2012-03-20 1:22 ` Stephen Warren
2012-03-20 1:31 ` Simon Glass
2012-03-20 1:46 ` Stephen Warren
2012-03-20 1:58 ` Simon Glass
2012-03-21 9:08 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F692230.4010509@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox