[U-Boot] [PATCH] tegra: Specify debugging serial port at boot.

Simon Glass
2012-03-21T17:13:12Z

Hi Stephen,

On Wed, Mar 21, 2012 at 10:09 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 03/21/2012 10:59 AM, Simon Glass wrote:
>> 3. What you propose is actually very easy to implement - it just
>> requires a new config like CONFIG_DEFAULT_UART or
>> CONFIG_PRE_CONSOLE_UART to be defined, and used in the
>> board_pre_console_putc() code.
>
> One question here: We already have CONFIG_TEGRA2_ENABLE_UART* and
> CONFIG_SYS_NS16550_COM* to select which UART to use. Surely one of those
> is appropriate for this, rather than inventing yet another config option?

These will only exist when CONFIG_OF_CONTROL is not defined. It might
confusing to use the same CONFIGs for the pre-console panic() case,
knowing that they will in fact be ignored in a normal boot. I would
suggest a new option, at least in the CONFIG_OF_CONTROL case where the
two options you mention will not be used.

Regards,
Simon