From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4][v2] powerpc/85xx:Make debug exception vector accessible
Date: Wed, 21 Mar 2012 11:34:11 -0500 [thread overview]
Message-ID: <4F6A0303.7080703@freescale.com> (raw)
In-Reply-To: <1332304982-10835-1-git-send-email-prabhakar@freescale.com>
On 03/20/2012 11:43 PM, Prabhakar Kushwaha wrote:
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> index 091af7c..d0b15a4 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright 2009-2011 Freescale Semiconductor, Inc
> + * Copyright 2009-2012 Freescale Semiconductor, Inc
> *
> * This program is free software; you can redistribute it and/or
> * modify it under the terms of the GNU General Public License as
> @@ -53,6 +53,36 @@ void setup_ifc(void)
>
> asm volatile("isync;msync;tlbwe;isync");
>
> +#if defined(CONFIG_E500) && defined(CONFIG_SYS_PPC_E500_DEBUG_TLB)
There is no need to check for CONFIG_E500 anywhere in
arch/powerpc/cpu/mpc85xx. mpc85xx implies CONFIG_E500.
I don't see anywhere in this patchset where you set
CONFIG_SYS_PPC_E500_DEBUG_TLB on any actual board. It should be set for
all e500v1/v2, not just so that debug works but so that this code
remains tested.
-Scott
next prev parent reply other threads:[~2012-03-21 16:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 4:43 [U-Boot] [PATCH 3/4][v2] powerpc/85xx:Make debug exception vector accessible Prabhakar Kushwaha
2012-03-21 16:34 ` Scott Wood [this message]
2012-03-21 17:04 ` Prabhakar Kushwaha
2012-03-21 17:08 ` Scott Wood
2012-03-21 19:52 ` Scott Wood
2012-03-22 5:52 ` Prabhakar Kushwaha
2012-03-22 19:43 ` Scott Wood
2012-03-22 19:51 ` Timur Tabi
2012-03-22 19:53 ` Scott Wood
2012-03-22 19:56 ` Timur Tabi
2012-03-22 19:59 ` Scott Wood
2012-03-23 11:44 ` Prabhakar Kushwaha
2012-03-23 18:14 ` Scott Wood
2012-03-24 2:24 ` Prabhakar Kushwaha
2012-03-26 18:14 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A0303.7080703@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox