[U-Boot] Patchwork housekeeping

[U-Boot] Patchwork housekeeping

[Graeme Russ]

Hello Custodians and Mailing List Aficionados,

I don't know if anyone has noticed, but patchwork is starting to collect
a rather large amount of cruft.

I occasionally jump onto patchwork and do a little housekeeping by marking
updated patches as 'Superceeded' and anything applied by Wolfgang as
'Accepted' (There may be a few patches that have been applied to custodian
tress that I marked as 'Accepted' when really they should have been marked
as 'Awaiting Upstream')

I really don't mind doing this housekeeping, but I would like to make a
few suggestions that will make the work a little easier:

 - If you are a custodian:
    o When you apply a patch to your repo, can you please assign it to
      yourself in patchwork and set it to 'Awaiting Upstream'
    o Reply to the ML with 'Applied to <repo>/<branch>'
    o When you send a pull request, create a bundle with all the patches
      that are to be pulled (you can create the bundle early and add
      patches as you apply them)
    o When Wolfgang pulls your repo, go to the bundle and mark all the
      patches 'Accepted'

 - If you are a patch submitter:
    o Visit http://patchwork.ozlabs.org/project/uboot/list/
    o Search for your patches by following the 'Filters'link and entering
      your name
    o Send and email (with 'patchwork' somewhere in the subject) to the ML
      with a list of patches that you submitted say more than one month
      ago. For each patch, please indicate if the patch is:
        * Superseded - By another patch (either by you or someone else)
        * Not Applicable - The patch can be ignored (was an RFC, was due
          to a misunderstanding, another patch did the same thing, etc)
        * Applied - Has been applied (state the repo and branch)
        * Rejected - Patch has been officially rejected
        * Waiting - You believe the patch is still valid but has not been
          applied (send a ping as a reply to the patch on the mailing list
          as well
        * Other - Please describe what state you feel the patch is in

Once I get the raw list down to a manageable level, I'll start to look at
the leftovers...

Regards,

"Your friendly Patchwork janitor" Graeme

[U-Boot] Patchwork housekeeping

[Marek Vasut]

Dear Graeme Russ,

> Hello Custodians and Mailing List Aficionados,
> 
> I don't know if anyone has noticed, but patchwork is starting to collect
> a rather large amount of cruft.
> 
> I occasionally jump onto patchwork and do a little housekeeping by marking
> updated patches as 'Superceeded' and anything applied by Wolfgang as
> 'Accepted' (There may be a few patches that have been applied to custodian
> tress that I marked as 'Accepted' when really they should have been marked
> as 'Awaiting Upstream')
> 
> I really don't mind doing this housekeeping, but I would like to make a
> few suggestions that will make the work a little easier:
> 
>  - If you are a custodian:
>     o When you apply a patch to your repo, can you please assign it to
>       yourself in patchwork and set it to 'Awaiting Upstream'
>     o Reply to the ML with 'Applied to <repo>/<branch>'
>     o When you send a pull request, create a bundle with all the patches
>       that are to be pulled (you can create the bundle early and add
>       patches as you apply them)
>     o When Wolfgang pulls your repo, go to the bundle and mark all the
>       patches 'Accepted'
> 
>  - If you are a patch submitter:
>     o Visit http://patchwork.ozlabs.org/project/uboot/list/
>     o Search for your patches by following the 'Filters'link and entering
>       your name
>     o Send and email (with 'patchwork' somewhere in the subject) to the ML
>       with a list of patches that you submitted say more than one month
>       ago. For each patch, please indicate if the patch is:
>         * Superseded - By another patch (either by you or someone else)
>         * Not Applicable - The patch can be ignored (was an RFC, was due
>           to a misunderstanding, another patch did the same thing, etc)
>         * Applied - Has been applied (state the repo and branch)
>         * Rejected - Patch has been officially rejected
>         * Waiting - You believe the patch is still valid but has not been
>           applied (send a ping as a reply to the patch on the mailing list
>           as well
>         * Other - Please describe what state you feel the patch is in
> 
> Once I get the raw list down to a manageable level, I'll start to look at
> the leftovers...

WAT ? Yet another ruleset ... and a long one while at that. Maybe we should 
cobble together an "U-Boot contributors guidebook" ... printed edition with 1k 
pages ;-D

We really need to make it easier for people to contribute to u-boot, these long 
rulesets only ward people away.

> 
> Regards,
> 
> "Your friendly Patchwork janitor" Graeme

Best regards,
Marek Vasut

[U-Boot] Patchwork housekeeping

[Graeme Russ]

Hi Marek,

On 03/22/2012 05:45 PM, Marek Vasut wrote:
> Dear Graeme Russ,
> 
>> Hello Custodians and Mailing List Aficionados,
>>
>> I don't know if anyone has noticed, but patchwork is starting to collect
>> a rather large amount of cruft.
>>
>> I occasionally jump onto patchwork and do a little housekeeping by marking
>> updated patches as 'Superceeded' and anything applied by Wolfgang as
>> 'Accepted' (There may be a few patches that have been applied to custodian
>> tress that I marked as 'Accepted' when really they should have been marked
>> as 'Awaiting Upstream')
>>
>> I really don't mind doing this housekeeping, but I would like to make a
>> few suggestions that will make the work a little easier:
>>
>>  - If you are a custodian:
>>     o When you apply a patch to your repo, can you please assign it to
>>       yourself in patchwork and set it to 'Awaiting Upstream'
>>     o Reply to the ML with 'Applied to <repo>/<branch>'
>>     o When you send a pull request, create a bundle with all the patches
>>       that are to be pulled (you can create the bundle early and add
>>       patches as you apply them)
>>     o When Wolfgang pulls your repo, go to the bundle and mark all the
>>       patches 'Accepted'
>>
>>  - If you are a patch submitter:
>>     o Visit http://patchwork.ozlabs.org/project/uboot/list/
>>     o Search for your patches by following the 'Filters'link and entering
>>       your name
>>     o Send and email (with 'patchwork' somewhere in the subject) to the ML
>>       with a list of patches that you submitted say more than one month
>>       ago. For each patch, please indicate if the patch is:
>>         * Superseded - By another patch (either by you or someone else)
>>         * Not Applicable - The patch can be ignored (was an RFC, was due
>>           to a misunderstanding, another patch did the same thing, etc)
>>         * Applied - Has been applied (state the repo and branch)
>>         * Rejected - Patch has been officially rejected
>>         * Waiting - You believe the patch is still valid but has not been
>>           applied (send a ping as a reply to the patch on the mailing list
>>           as well
>>         * Other - Please describe what state you feel the patch is in
>>
>> Once I get the raw list down to a manageable level, I'll start to look at
>> the leftovers...
> 
> WAT ? Yet another ruleset ... and a long one while at that. Maybe we should 
> cobble together an "U-Boot contributors guidebook" ... printed edition with 1k 
> pages ;-D

The submission rules (http://www.denx.de/wiki/U-Boot/Patches) are pretty
clear and concise (I've added a not about starting the subject with a tag)

> We really need to make it easier for people to contribute to u-boot, these long 
> rulesets only ward people away.

This patchwork cleanup should really only be a once off to try and get
things cleaned up a bit. There are patches in patchwork from 2009, if we
can get some of the stale patches cleaned out (and contact the submitters
to see if they are interested in resubmitting or verifying re-based
patches) then we will all be better off.

Nothing is more discouraging to patch submitters than patches that get ignored.

Regards,

Graeme

[U-Boot] Patchwork housekeeping

[Marek Vasut]

Dear Graeme Russ,

> Hi Marek,
> 
> On 03/22/2012 05:45 PM, Marek Vasut wrote:
> > Dear Graeme Russ,
> > 
> >> Hello Custodians and Mailing List Aficionados,
> >> 
> >> I don't know if anyone has noticed, but patchwork is starting to collect
> >> a rather large amount of cruft.
> >> 
> >> I occasionally jump onto patchwork and do a little housekeeping by
> >> marking updated patches as 'Superceeded' and anything applied by
> >> Wolfgang as 'Accepted' (There may be a few patches that have been
> >> applied to custodian tress that I marked as 'Accepted' when really they
> >> should have been marked as 'Awaiting Upstream')
> >> 
> >> I really don't mind doing this housekeeping, but I would like to make a
> >> 
> >> few suggestions that will make the work a little easier:
> >>  - If you are a custodian:
> >>     o When you apply a patch to your repo, can you please assign it to
> >>     
> >>       yourself in patchwork and set it to 'Awaiting Upstream'
> >>     
> >>     o Reply to the ML with 'Applied to <repo>/<branch>'
> >>     o When you send a pull request, create a bundle with all the patches
> >>     
> >>       that are to be pulled (you can create the bundle early and add
> >>       patches as you apply them)
> >>     
> >>     o When Wolfgang pulls your repo, go to the bundle and mark all the
> >>     
> >>       patches 'Accepted'
> >>  
> >>  - If you are a patch submitter:
> >>     o Visit http://patchwork.ozlabs.org/project/uboot/list/
> >>     o Search for your patches by following the 'Filters'link and
> >>     entering
> >>     
> >>       your name
> >>     
> >>     o Send and email (with 'patchwork' somewhere in the subject) to the
> >>     ML
> >>     
> >>       with a list of patches that you submitted say more than one month
> >>       
> >>       ago. For each patch, please indicate if the patch is:
> >>         * Superseded - By another patch (either by you or someone else)
> >>         * Not Applicable - The patch can be ignored (was an RFC, was due
> >>         
> >>           to a misunderstanding, another patch did the same thing, etc)
> >>         
> >>         * Applied - Has been applied (state the repo and branch)
> >>         * Rejected - Patch has been officially rejected
> >>         * Waiting - You believe the patch is still valid but has not
> >>         been
> >>         
> >>           applied (send a ping as a reply to the patch on the mailing
> >>           list as well
> >>         
> >>         * Other - Please describe what state you feel the patch is in
> >> 
> >> Once I get the raw list down to a manageable level, I'll start to look
> >> at the leftovers...
> > 
> > WAT ? Yet another ruleset ... and a long one while at that. Maybe we
> > should cobble together an "U-Boot contributors guidebook" ... printed
> > edition with 1k pages ;-D
> 
> The submission rules (http://www.denx.de/wiki/U-Boot/Patches) are pretty
> clear and concise (I've added a not about starting the subject with a tag)

Some distilled down version for first-time comers won't hurt of that page.
> 
> > We really need to make it easier for people to contribute to u-boot,
> > these long rulesets only ward people away.
> 
> This patchwork cleanup should really only be a once off to try and get
> things cleaned up a bit. There are patches in patchwork from 2009, if we
> can get some of the stale patches cleaned out (and contact the submitters
> to see if they are interested in resubmitting or verifying re-based
> patches) then we will all be better off.

Agreed
> 
> Nothing is more discouraging to patch submitters than patches that get
> ignored.

Yes
> 
> Regards,
> 
> Graeme

Thanks for working on this, Graeme, I really appreciate that

Best regards,
Marek Vasut

[U-Boot] Patchwork housekeeping

[Tom Rini]

On 03/21/2012 07:58 PM, Graeme Russ wrote:
> Hello Custodians and Mailing List Aficionados,
>
> I don't know if anyone has noticed, but patchwork is starting to collect
> a rather large amount of cruft.

Do we, or do we not have the magic "update patchwork when the master 
repo gets a patch" hook setup?  It's not fool-proof, but it works well.

-- 
Tom

[U-Boot] Patchwork housekeeping

[McClintock Matthew-B29882]

On Thu, Mar 22, 2012 at 10:08 AM, Tom Rini <trini@ti.com> wrote:
> On 03/21/2012 07:58 PM, Graeme Russ wrote:
>>
>> Hello Custodians and Mailing List Aficionados,
>>
>> I don't know if anyone has noticed, but patchwork is starting to collect
>> a rather large amount of cruft.
>
>
> Do we, or do we not have the magic "update patchwork when the master repo
> gets a patch" hook setup? ?It's not fool-proof, but it works well.

Where does one find this?

-M

[U-Boot] Patchwork housekeeping

[Tom Rini]

On 03/22/2012 09:09 AM, McClintock Matthew-B29882 wrote:
> On Thu, Mar 22, 2012 at 10:08 AM, Tom Rini<trini@ti.com>  wrote:
>> On 03/21/2012 07:58 PM, Graeme Russ wrote:
>>>
>>> Hello Custodians and Mailing List Aficionados,
>>>
>>> I don't know if anyone has noticed, but patchwork is starting to collect
>>> a rather large amount of cruft.
>>
>>
>> Do we, or do we not have the magic "update patchwork when the master repo
>> gets a patch" hook setup?  It's not fool-proof, but it works well.
>
> Where does one find this?

I'm just a user over in OpenEmbedded-land where it's in use.  Khem?

-- 
Tom

[U-Boot] Patchwork housekeeping

[Khem Raj]

On Thu, Mar 22, 2012 at 10:22 AM, Tom Rini <trini@ti.com> wrote:
>>>>
>>>> I don't know if anyone has noticed, but patchwork is starting to collect
>>>> a rather large amount of cruft.
>>>
>>>
>>>
>>> Do we, or do we not have the magic "update patchwork when the master repo
>>> gets a patch" hook setup? ?It's not fool-proof, but it works well.
>>
>>
>> Where does one find this?
>
>
> I'm just a user over in OpenEmbedded-land where it's in use. ?Khem?

Yes. I am the one who set it up on OE. Its setup as post-receive hook.
I am attaching the sample to this mail.

Thanks
-Khem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: post-receive.patchwork.oe
Type: application/octet-stream
Size: 1881 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120322/3fddeb12/attachment.obj>

[U-Boot] Patchwork housekeeping

[Scott Wood]

On 03/21/2012 09:58 PM, Graeme Russ wrote:
> Hello Custodians and Mailing List Aficionados,
> 
> I don't know if anyone has noticed, but patchwork is starting to collect
> a rather large amount of cruft.
> 
> I occasionally jump onto patchwork and do a little housekeeping by marking
> updated patches as 'Superceeded' and anything applied by Wolfgang as
> 'Accepted' (There may be a few patches that have been applied to custodian
> tress that I marked as 'Accepted' when really they should have been marked
> as 'Awaiting Upstream')
> 
> I really don't mind doing this housekeeping, but I would like to make a
> few suggestions that will make the work a little easier:
> 
>  - If you are a custodian:
>     o When you apply a patch to your repo, can you please assign it to
>       yourself in patchwork and set it to 'Awaiting Upstream'
>     o Reply to the ML with 'Applied to <repo>/<branch>'
>     o When you send a pull request, create a bundle with all the patches
>       that are to be pulled (you can create the bundle early and add
>       patches as you apply them)
>     o When Wolfgang pulls your repo, go to the bundle and mark all the
>       patches 'Accepted'

A while back I recall it being established that patches should be marked
"accepted" when they go into the custodian repo -- has this changed?

-Scott

[U-Boot] Patchwork housekeeping

[Vladimir Zapolskiy]

Hi Graeme,

On 22.03.2012 04:58, Graeme Russ wrote:
> Hello Custodians and Mailing List Aficionados,
>
> I don't know if anyone has noticed, but patchwork is starting to collect
> a rather large amount of cruft.
>
> I occasionally jump onto patchwork and do a little housekeeping by marking
> updated patches as 'Superceeded' and anything applied by Wolfgang as
> 'Accepted' (There may be a few patches that have been applied to custodian
> tress that I marked as 'Accepted' when really they should have been marked
> as 'Awaiting Upstream')
>
> I really don't mind doing this housekeeping, but I would like to make a
> few suggestions that will make the work a little easier:
>
>   - If you are a custodian:
>      o When you apply a patch to your repo, can you please assign it to
>        yourself in patchwork and set it to 'Awaiting Upstream'
>      o Reply to the ML with 'Applied to<repo>/<branch>'
>      o When you send a pull request, create a bundle with all the patches
>        that are to be pulled (you can create the bundle early and add
>        patches as you apply them)
>      o When Wolfgang pulls your repo, go to the bundle and mark all the
>        patches 'Accepted'
>
>   - If you are a patch submitter:
>      o Visit http://patchwork.ozlabs.org/project/uboot/list/
>      o Search for your patches by following the 'Filters'link and entering
>        your name
>      o Send and email (with 'patchwork' somewhere in the subject) to the ML
>        with a list of patches that you submitted say more than one month
http://patchwork.ozlabs.org/patch/135526/
http://patchwork.ozlabs.org/patch/135699/
http://patchwork.ozlabs.org/patch/135697/
http://patchwork.ozlabs.org/patch/135698/

That's the list of patches sent in January, still no progress.

>        ago. For each patch, please indicate if the patch is:
>          * Superseded - By another patch (either by you or someone else)
>          * Not Applicable - The patch can be ignored (was an RFC, was due
>            to a misunderstanding, another patch did the same thing, etc)
>          * Applied - Has been applied (state the repo and branch)
>          * Rejected - Patch has been officially rejected
>          * Waiting - You believe the patch is still valid but has not been
>            applied (send a ping as a reply to the patch on the mailing list
>            as well
I marked the patches as `awaiting upstream'.

>          * Other - Please describe what state you feel the patch is in
>
> Once I get the raw list down to a manageable level, I'll start to look at
> the leftovers...
>

--
With best wishes,
Vladimir

[U-Boot] Patchwork housekeeping

[Andy Fleming]

On Mar 26, 2012, at 12:30 PM, Vladimir Zapolskiy wrote:

> Hi Graeme,
> 
> On 22.03.2012 04:58, Graeme Russ wrote:
>> Hello Custodians and Mailing List Aficionados,
>> 
>> I don't know if anyone has noticed, but patchwork is starting to collect
>> a rather large amount of cruft.
>> 
>> I occasionally jump onto patchwork and do a little housekeeping by marking
>> updated patches as 'Superceeded' and anything applied by Wolfgang as
>> 'Accepted' (There may be a few patches that have been applied to custodian
>> tress that I marked as 'Accepted' when really they should have been marked
>> as 'Awaiting Upstream')
>> 
>> I really don't mind doing this housekeeping, but I would like to make a
>> few suggestions that will make the work a little easier:
>> 
>>  - If you are a custodian:
>>     o When you apply a patch to your repo, can you please assign it to
>>       yourself in patchwork and set it to 'Awaiting Upstream'
>>     o Reply to the ML with 'Applied to<repo>/<branch>'
>>     o When you send a pull request, create a bundle with all the patches
>>       that are to be pulled (you can create the bundle early and add
>>       patches as you apply them)
>>     o When Wolfgang pulls your repo, go to the bundle and mark all the
>>       patches 'Accepted'
>> 
>>  - If you are a patch submitter:
>>     o Visit http://patchwork.ozlabs.org/project/uboot/list/
>>     o Search for your patches by following the 'Filters'link and entering
>>       your name
>>     o Send and email (with 'patchwork' somewhere in the subject) to the ML
>>       with a list of patches that you submitted say more than one month
> http://patchwork.ozlabs.org/patch/135526/
> http://patchwork.ozlabs.org/patch/135699/
> http://patchwork.ozlabs.org/patch/135697/
> http://patchwork.ozlabs.org/patch/135698/
> 
> That's the list of patches sent in January, still no progress.
> 
>>       ago. For each patch, please indicate if the patch is:
>>         * Superseded - By another patch (either by you or someone else)
>>         * Not Applicable - The patch can be ignored (was an RFC, was due
>>           to a misunderstanding, another patch did the same thing, etc)
>>         * Applied - Has been applied (state the repo and branch)
>>         * Rejected - Patch has been officially rejected
>>         * Waiting - You believe the patch is still valid but has not been
>>           applied (send a ping as a reply to the patch on the mailing list
>>           as well
> I marked the patches as `awaiting upstream'.


Awaiting upstream means that the patches have been applied already, and are waiting for Wolfgang's pull. I suspect this is not the case for your patches. If it is the case, then there's probably no need to mention it, as Wolfgang will eventually pull that tree.

Andy

[U-Boot] Patchwork housekeeping

[Vladimir Zapolskiy]

On 26.03.2012 20:36, Andy Fleming wrote:
>
> On Mar 26, 2012, at 12:30 PM, Vladimir Zapolskiy wrote:
>
>> Hi Graeme,
>>
>> On 22.03.2012 04:58, Graeme Russ wrote:
>>> Hello Custodians and Mailing List Aficionados,
>>>
>>> I don't know if anyone has noticed, but patchwork is starting to collect
>>> a rather large amount of cruft.
>>>
>>> I occasionally jump onto patchwork and do a little housekeeping by marking
>>> updated patches as 'Superceeded' and anything applied by Wolfgang as
>>> 'Accepted' (There may be a few patches that have been applied to custodian
>>> tress that I marked as 'Accepted' when really they should have been marked
>>> as 'Awaiting Upstream')
>>>
>>> I really don't mind doing this housekeeping, but I would like to make a
>>> few suggestions that will make the work a little easier:
>>>
>>>   - If you are a custodian:
>>>      o When you apply a patch to your repo, can you please assign it to
>>>        yourself in patchwork and set it to 'Awaiting Upstream'
>>>      o Reply to the ML with 'Applied to<repo>/<branch>'
>>>      o When you send a pull request, create a bundle with all the patches
>>>        that are to be pulled (you can create the bundle early and add
>>>        patches as you apply them)
>>>      o When Wolfgang pulls your repo, go to the bundle and mark all the
>>>        patches 'Accepted'
>>>
>>>   - If you are a patch submitter:
>>>      o Visit http://patchwork.ozlabs.org/project/uboot/list/
>>>      o Search for your patches by following the 'Filters'link and entering
>>>        your name
>>>      o Send and email (with 'patchwork' somewhere in the subject) to the ML
>>>        with a list of patches that you submitted say more than one month
>> http://patchwork.ozlabs.org/patch/135526/
>> http://patchwork.ozlabs.org/patch/135699/
>> http://patchwork.ozlabs.org/patch/135697/
>> http://patchwork.ozlabs.org/patch/135698/
>>
>> That's the list of patches sent in January, still no progress.
>>
>>>        ago. For each patch, please indicate if the patch is:
>>>          * Superseded - By another patch (either by you or someone else)
>>>          * Not Applicable - The patch can be ignored (was an RFC, was due
>>>            to a misunderstanding, another patch did the same thing, etc)
>>>          * Applied - Has been applied (state the repo and branch)
>>>          * Rejected - Patch has been officially rejected
>>>          * Waiting - You believe the patch is still valid but has not been
>>>            applied (send a ping as a reply to the patch on the mailing list
>>>            as well
>> I marked the patches as `awaiting upstream'.
>
>
> Awaiting upstream means that the patches have been applied already, and are waiting for Wolfgang's pull. I suspect this is not the case for your patches. If it is the case, then there's probably no need to mention it, as Wolfgang will eventually pull that tree.
>
Thanks for correction, I haven't found literally a state `Waiting' among options 
as it was recommended by Graeme, however I have to change it certainly.

Should it be `Under Review' or which state, if a patch is valid, but hasn't been 
applied yet?

--
Vladimir