From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4][v2] powerpc/85xx:Make debug exception vector accessible
Date: Thu, 22 Mar 2012 14:59:30 -0500 [thread overview]
Message-ID: <4F6B84A2.6020204@freescale.com> (raw)
In-Reply-To: <4F6B83D4.6090007@freescale.com>
On 03/22/2012 02:56 PM, Timur Tabi wrote:
> Scott Wood wrote:
>> Either it's needed, or we should get rid of CONFIG_ENABLE_36BIT_PHYS
>> entirely. Either way, we should test the results on e500v1 hardware.
>
> That macro conditionally enables support for MAS7:
>
> #if defined(CONFIG_ENABLE_36BIT_PHYS)
> ori r0,r0,HID0_ENMAS7 at l /* Enable MAS7 */
> #endif
>
> So I don't think we can get rid of it, otherwise I suspect an e500v1
> operating system will not work on an e500v2 part.
Fine, keep it for that (though I'd argue that if that were the concern,
we should have been clearing it before we enter the OS, and the Os can
set it if it wants). But what about in write_tlb, or tlb.c?
There's obviously an existing attempt to avoid touching MAS7 if
CONFIG_ENABLE_36BIT_PHYS is not set. Either that's unnecessary and we
should remove it, or we should continue adhering to it.
-Scott
next prev parent reply other threads:[~2012-03-22 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 4:43 [U-Boot] [PATCH 3/4][v2] powerpc/85xx:Make debug exception vector accessible Prabhakar Kushwaha
2012-03-21 16:34 ` Scott Wood
2012-03-21 17:04 ` Prabhakar Kushwaha
2012-03-21 17:08 ` Scott Wood
2012-03-21 19:52 ` Scott Wood
2012-03-22 5:52 ` Prabhakar Kushwaha
2012-03-22 19:43 ` Scott Wood
2012-03-22 19:51 ` Timur Tabi
2012-03-22 19:53 ` Scott Wood
2012-03-22 19:56 ` Timur Tabi
2012-03-22 19:59 ` Scott Wood [this message]
2012-03-23 11:44 ` Prabhakar Kushwaha
2012-03-23 18:14 ` Scott Wood
2012-03-24 2:24 ` Prabhakar Kushwaha
2012-03-26 18:14 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6B84A2.6020204@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox