* [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select
@ 2012-03-23 0:29 Fabio Estevam
2012-03-23 0:29 ` [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Fabio Estevam @ 2012-03-23 0:29 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
Provide default values for SPI bus and chip select.
This allows the command "sf probe" to work without passing SPI bus and chip
select numbers as arguments.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx28evk.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 04967d7..112fda4 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -186,6 +186,8 @@
/* SPI Flash */
#ifdef CONFIG_CMD_SF
#define CONFIG_SPI_FLASH
+#define CONFIG_SF_DEFAULT_BUS 2
+#define CONFIG_SF_DEFAULT_CS 0
/* this may vary and depends on the installed chip */
#define CONFIG_SPI_FLASH_SST
#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS
2012-03-23 0:29 [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Fabio Estevam
@ 2012-03-23 0:29 ` Fabio Estevam
2012-03-23 8:39 ` Marek Vasut
2012-03-23 9:30 ` Stefano Babic
2012-03-23 8:38 ` [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Marek Vasut
2012-03-23 9:30 ` Stefano Babic
2 siblings, 2 replies; 9+ messages in thread
From: Fabio Estevam @ 2012-03-23 0:29 UTC (permalink / raw)
To: u-boot
CONFIG_SPI_FLASH_CS is not used anywhere.
Use CONFIG_SF_DEFAULT_CS instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/efikamx.h | 2 +-
include/configs/m28evk.h | 2 +-
include/configs/vision2.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
index af542fa..120055f 100644
--- a/include/configs/efikamx.h
+++ b/include/configs/efikamx.h
@@ -113,7 +113,7 @@
#define CONFIG_SPI_FLASH
#define CONFIG_SPI_FLASH_SST
-#define CONFIG_SPI_FLASH_CS (1 | 121 << 8)
+#define CONFIG_SF_DEFAULT_CS (1 | 121 << 8)
#define CONFIG_SF_DEFAULT_MODE (SPI_MODE_0)
#define CONFIG_SF_DEFAULT_SPEED 25000000
diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
index 4d59153..4b97c71 100644
--- a/include/configs/m28evk.h
+++ b/include/configs/m28evk.h
@@ -252,7 +252,7 @@
#ifdef CONFIG_CMD_SF
#define CONFIG_SPI_FLASH
#define CONFIG_SPI_FLASH_STMICRO
-#define CONFIG_SPI_FLASH_CS 2
+#define CONFIG_SF_DEFAULT_CS 2
#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
#define CONFIG_SF_DEFAULT_SPEED 24000000
diff --git a/include/configs/vision2.h b/include/configs/vision2.h
index 35b71f7..f6904f3 100644
--- a/include/configs/vision2.h
+++ b/include/configs/vision2.h
@@ -72,7 +72,7 @@
* Use gpio 4 pin 25 as chip select for SPI flash
* This corresponds to gpio 121
*/
-#define CONFIG_SPI_FLASH_CS (1 | (121 << 8))
+#define CONFIG_SF_DEFAULT_CS (1 | (121 << 8))
#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
#define CONFIG_SF_DEFAULT_SPEED 25000000
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS
2012-03-23 0:29 ` [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS Fabio Estevam
@ 2012-03-23 8:39 ` Marek Vasut
2012-03-23 9:08 ` Stefano Babic
2012-03-23 9:30 ` Stefano Babic
1 sibling, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2012-03-23 8:39 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> CONFIG_SPI_FLASH_CS is not used anywhere.
>
> Use CONFIG_SF_DEFAULT_CS instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/efikamx.h | 2 +-
> include/configs/m28evk.h | 2 +-
> include/configs/vision2.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
> index af542fa..120055f 100644
> --- a/include/configs/efikamx.h
> +++ b/include/configs/efikamx.h
> @@ -113,7 +113,7 @@
>
> #define CONFIG_SPI_FLASH
> #define CONFIG_SPI_FLASH_SST
> -#define CONFIG_SPI_FLASH_CS (1 | 121 << 8)
> +#define CONFIG_SF_DEFAULT_CS (1 | 121 << 8)
> #define CONFIG_SF_DEFAULT_MODE (SPI_MODE_0)
> #define CONFIG_SF_DEFAULT_SPEED 25000000
>
> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> index 4d59153..4b97c71 100644
> --- a/include/configs/m28evk.h
> +++ b/include/configs/m28evk.h
> @@ -252,7 +252,7 @@
> #ifdef CONFIG_CMD_SF
> #define CONFIG_SPI_FLASH
> #define CONFIG_SPI_FLASH_STMICRO
> -#define CONFIG_SPI_FLASH_CS 2
> +#define CONFIG_SF_DEFAULT_CS 2
are you sure about this? Are you sure this does the same thing?
> #define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
> #define CONFIG_SF_DEFAULT_SPEED 24000000
>
> diff --git a/include/configs/vision2.h b/include/configs/vision2.h
> index 35b71f7..f6904f3 100644
> --- a/include/configs/vision2.h
> +++ b/include/configs/vision2.h
> @@ -72,7 +72,7 @@
> * Use gpio 4 pin 25 as chip select for SPI flash
> * This corresponds to gpio 121
> */
> -#define CONFIG_SPI_FLASH_CS (1 | (121 << 8))
> +#define CONFIG_SF_DEFAULT_CS (1 | (121 << 8))
> #define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
> #define CONFIG_SF_DEFAULT_SPEED 25000000
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS
2012-03-23 8:39 ` Marek Vasut
@ 2012-03-23 9:08 ` Stefano Babic
2012-03-23 9:18 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: Stefano Babic @ 2012-03-23 9:08 UTC (permalink / raw)
To: u-boot
On 23/03/2012 09:39, Marek Vasut wrote:
> Dear Fabio Estevam,
>
>> CONFIG_SPI_FLASH_CS is not used anywhere.
>>
>> Use CONFIG_SF_DEFAULT_CS instead.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> include/configs/efikamx.h | 2 +-
>> include/configs/m28evk.h | 2 +-
>> include/configs/vision2.h | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
>> index af542fa..120055f 100644
>> --- a/include/configs/efikamx.h
>> +++ b/include/configs/efikamx.h
>> @@ -113,7 +113,7 @@
>>
>> #define CONFIG_SPI_FLASH
>> #define CONFIG_SPI_FLASH_SST
>> -#define CONFIG_SPI_FLASH_CS (1 | 121 << 8)
>> +#define CONFIG_SF_DEFAULT_CS (1 | 121 << 8)
>> #define CONFIG_SF_DEFAULT_MODE (SPI_MODE_0)
>> #define CONFIG_SF_DEFAULT_SPEED 25000000
>>
>> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
>> index 4d59153..4b97c71 100644
>> --- a/include/configs/m28evk.h
>> +++ b/include/configs/m28evk.h
>> @@ -252,7 +252,7 @@
>> #ifdef CONFIG_CMD_SF
>> #define CONFIG_SPI_FLASH
>> #define CONFIG_SPI_FLASH_STMICRO
>> -#define CONFIG_SPI_FLASH_CS 2
>> +#define CONFIG_SF_DEFAULT_CS 2
>
> are you sure about this? Are you sure this does the same thing?
Are we sure that CONFIG_SPI_FLASH_CS has still a meaning ? It seems to
me that SPI flash uses now CONFIG_SF_DEFAULT_CS, and we should exchange
other boards exactly as Fabio does for mx28evk. Is there still code
using CONFIG_SPI_FLASH_CS ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS
2012-03-23 9:08 ` Stefano Babic
@ 2012-03-23 9:18 ` Marek Vasut
2012-03-23 9:26 ` Stefano Babic
0 siblings, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2012-03-23 9:18 UTC (permalink / raw)
To: u-boot
Dear Stefano Babic,
> On 23/03/2012 09:39, Marek Vasut wrote:
> > Dear Fabio Estevam,
> >
> >> CONFIG_SPI_FLASH_CS is not used anywhere.
> >>
> >> Use CONFIG_SF_DEFAULT_CS instead.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >> ---
> >>
> >> include/configs/efikamx.h | 2 +-
> >> include/configs/m28evk.h | 2 +-
> >> include/configs/vision2.h | 2 +-
> >> 3 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
> >> index af542fa..120055f 100644
> >> --- a/include/configs/efikamx.h
> >> +++ b/include/configs/efikamx.h
> >> @@ -113,7 +113,7 @@
> >>
> >> #define CONFIG_SPI_FLASH
> >> #define CONFIG_SPI_FLASH_SST
> >>
> >> -#define CONFIG_SPI_FLASH_CS (1 | 121 << 8)
> >> +#define CONFIG_SF_DEFAULT_CS (1 | 121 << 8)
> >>
> >> #define CONFIG_SF_DEFAULT_MODE (SPI_MODE_0)
> >> #define CONFIG_SF_DEFAULT_SPEED 25000000
> >>
> >> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> >> index 4d59153..4b97c71 100644
> >> --- a/include/configs/m28evk.h
> >> +++ b/include/configs/m28evk.h
> >> @@ -252,7 +252,7 @@
> >>
> >> #ifdef CONFIG_CMD_SF
> >> #define CONFIG_SPI_FLASH
> >> #define CONFIG_SPI_FLASH_STMICRO
> >>
> >> -#define CONFIG_SPI_FLASH_CS 2
> >> +#define CONFIG_SF_DEFAULT_CS 2
> >
> > are you sure about this? Are you sure this does the same thing?
>
> Are we sure that CONFIG_SPI_FLASH_CS has still a meaning ? It seems to
> me that SPI flash uses now CONFIG_SF_DEFAULT_CS, and we should exchange
> other boards exactly as Fabio does for mx28evk. Is there still code
> using CONFIG_SPI_FLASH_CS ?
No, that's why I'm asking. And I see no use of CONFIG_SPI_FLASH_CS. All right
then:
Acked-by: Marek Vasut <marex@denx.de>
>
> Best regards,
> Stefano Babic
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS
2012-03-23 9:18 ` Marek Vasut
@ 2012-03-23 9:26 ` Stefano Babic
0 siblings, 0 replies; 9+ messages in thread
From: Stefano Babic @ 2012-03-23 9:26 UTC (permalink / raw)
To: u-boot
On 23/03/2012 10:18, Marek Vasut wrote:
>
> No, that's why I'm asking. And I see no use of CONFIG_SPI_FLASH_CS. All right
> then:
>
> Acked-by: Marek Vasut <marex@denx.de>
Ok, then everything is clear.
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS
2012-03-23 0:29 ` [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS Fabio Estevam
2012-03-23 8:39 ` Marek Vasut
@ 2012-03-23 9:30 ` Stefano Babic
1 sibling, 0 replies; 9+ messages in thread
From: Stefano Babic @ 2012-03-23 9:30 UTC (permalink / raw)
To: u-boot
On 23/03/2012 01:29, Fabio Estevam wrote:
> CONFIG_SPI_FLASH_CS is not used anywhere.
>
> Use CONFIG_SF_DEFAULT_CS instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select
2012-03-23 0:29 [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Fabio Estevam
2012-03-23 0:29 ` [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS Fabio Estevam
@ 2012-03-23 8:38 ` Marek Vasut
2012-03-23 9:30 ` Stefano Babic
2 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2012-03-23 8:38 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Provide default values for SPI bus and chip select.
>
> This allows the command "sf probe" to work without passing SPI bus and chip
> select numbers as arguments.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> include/configs/mx28evk.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 04967d7..112fda4 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -186,6 +186,8 @@
> /* SPI Flash */
> #ifdef CONFIG_CMD_SF
> #define CONFIG_SPI_FLASH
> +#define CONFIG_SF_DEFAULT_BUS 2
> +#define CONFIG_SF_DEFAULT_CS 0
> /* this may vary and depends on the installed chip */
> #define CONFIG_SPI_FLASH_SST
> #define CONFIG_SF_DEFAULT_MODE SPI_MODE_0
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select
2012-03-23 0:29 [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Fabio Estevam
2012-03-23 0:29 ` [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS Fabio Estevam
2012-03-23 8:38 ` [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Marek Vasut
@ 2012-03-23 9:30 ` Stefano Babic
2 siblings, 0 replies; 9+ messages in thread
From: Stefano Babic @ 2012-03-23 9:30 UTC (permalink / raw)
To: u-boot
On 23/03/2012 01:29, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Provide default values for SPI bus and chip select.
>
> This allows the command "sf probe" to work without passing SPI bus and chip
> select numbers as arguments.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-03-23 9:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-23 0:29 [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Fabio Estevam
2012-03-23 0:29 ` [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS Fabio Estevam
2012-03-23 8:39 ` Marek Vasut
2012-03-23 9:08 ` Stefano Babic
2012-03-23 9:18 ` Marek Vasut
2012-03-23 9:26 ` Stefano Babic
2012-03-23 9:30 ` Stefano Babic
2012-03-23 8:38 ` [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Marek Vasut
2012-03-23 9:30 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox