* [U-Boot] [PATCH] mx53ard: Initialize return code with error
@ 2012-03-19 23:41 Fabio Estevam
2012-03-20 6:41 ` Stefano Babic
2012-03-23 10:37 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2012-03-19 23:41 UTC (permalink / raw)
To: u-boot
The variable "rc" is the return of board_eth_init() function. Initialize
it with an error code, so that this function can return an error when
CONFIG_SMC911X is not set.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx53ard/mx53ard.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/freescale/mx53ard/mx53ard.c b/board/freescale/mx53ard/mx53ard.c
index e90e39e..2d21584 100644
--- a/board/freescale/mx53ard/mx53ard.c
+++ b/board/freescale/mx53ard/mx53ard.c
@@ -287,7 +287,7 @@ int board_init(void)
int board_eth_init(bd_t *bis)
{
- int rc = 0;
+ int rc = -ENODEV;
weim_smc911x_iomux();
weim_cs1_settings();
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] mx53ard: Initialize return code with error
2012-03-19 23:41 [U-Boot] [PATCH] mx53ard: Initialize return code with error Fabio Estevam
@ 2012-03-20 6:41 ` Stefano Babic
2012-03-23 10:37 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-03-20 6:41 UTC (permalink / raw)
To: u-boot
On 20/03/2012 00:41, Fabio Estevam wrote:
> The variable "rc" is the return of board_eth_init() function. Initialize
> it with an error code, so that this function can return an error when
> CONFIG_SMC911X is not set.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/freescale/mx53ard/mx53ard.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/board/freescale/mx53ard/mx53ard.c b/board/freescale/mx53ard/mx53ard.c
> index e90e39e..2d21584 100644
> --- a/board/freescale/mx53ard/mx53ard.c
> +++ b/board/freescale/mx53ard/mx53ard.c
> @@ -287,7 +287,7 @@ int board_init(void)
>
> int board_eth_init(bd_t *bis)
> {
> - int rc = 0;
> + int rc = -ENODEV;
>
> weim_smc911x_iomux();
> weim_cs1_settings();
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] mx53ard: Initialize return code with error
2012-03-19 23:41 [U-Boot] [PATCH] mx53ard: Initialize return code with error Fabio Estevam
2012-03-20 6:41 ` Stefano Babic
@ 2012-03-23 10:37 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-03-23 10:37 UTC (permalink / raw)
To: u-boot
On 20/03/2012 00:41, Fabio Estevam wrote:
> The variable "rc" is the return of board_eth_init() function. Initialize
> it with an error code, so that this function can return an error when
> CONFIG_SMC911X is not set.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-23 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-19 23:41 [U-Boot] [PATCH] mx53ard: Initialize return code with error Fabio Estevam
2012-03-20 6:41 ` Stefano Babic
2012-03-23 10:37 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox