From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 26 Mar 2012 15:42:55 +0200 Subject: [U-Boot] [PATCH 2/2] i.MX6: mx6q_sabrelite: add SATA bindings In-Reply-To: <4F7070B6.6090200@boundarydevices.com> References: <1332716409-29225-1-git-send-email-eric.nelson@boundarydevices.com> <1332716409-29225-3-git-send-email-eric.nelson@boundarydevices.com> <4F702A6A.3000406@denx.de> <4F7070B6.6090200@boundarydevices.com> Message-ID: <4F70725F.8080105@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 26/03/2012 15:35, Eric Nelson wrote: > On 03/26/2012 01:35 AM, Stefano Babic wrote: >> On 26/03/2012 01:00, Eric Nelson wrote: >>> V2 has been stripped of the board-independent changes and >>> uses clrsetbits_le32() instead of twiddling bits by hand. >>> >>> Signed-off-by: Eric Nelson >>> --- >> >> Hi Eric, >> >>> board/freescale/mx6qsabrelite/mx6qsabrelite.c | 32 >>> +++++++++++++++++++++++++ >>> include/configs/mx6qsabrelite.h | 13 ++++++++++ >>> 2 files changed, 45 insertions(+), 0 deletions(-) >>> >>> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c >>> b/board/freescale/mx6qsabrelite/mx6qsabrelite.c >>> index 1d09a72..afb1245 100644 >>> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c >>> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c >>> @@ -25,6 +25,8 @@ >>> #include >>> #include >>> #include >>> +#include >>> +#include >>> #include >>> #include >>> #include >>> @@ -267,6 +269,32 @@ int board_eth_init(bd_t *bis) >>> return 0; >>> } >>> >>> +#ifdef CONFIG_CMD_SATA >>> + >>> +int setup_sata(void) >>> +{ >>> + int rval = enable_sata_clock(); >> >> What about to return at this point if there is an error ? >> > > I'm not sure I understand. Do you mean re-structure the code with > two returns like this? No, much easier - I find the code is easy to understand if it looks like if the function returns immediately in case of error. if (do_something()) return ERROR; < code when no error happens> Your enable_sata_clock() return only -1 in case of error. You could easy write: if (enable_sata_clock()) return -1 (or better a value in errno.h) struct iomuxc_base_regs *const iomuxc_regs = (struct iomuxc_base_regs *) IOMUXC_BASE_ADDR; clrsetbits_le32(&iomuxc_regs->gpr[13], IOMUXC_GPR13_SATA_MASK, IOMUXC_GPR13_SATA_PHY_8_RXEQ_3P0DB |IOMUXC_GPR13_SATA_PHY_7_SATA2M |IOMUXC_GPR13_SATA_SPEED_3G |(3<