From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 26 Mar 2012 11:17:30 -0500 Subject: [U-Boot] [PATCH] cmd_nand: Fix possible uninited max_size variable In-Reply-To: <1332545238-877-1-git-send-email-marex@denx.de> References: <1332545238-877-1-git-send-email-marex@denx.de> Message-ID: <4F70969A.7050504@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/23/2012 06:27 PM, Marek Vasut wrote: > GCC 4.7 error: > cmd_nand.c: In function ?arg_off_size?: > cmd_nand.c:216:5: warning: ?maxsize? may be used uninitialized in this function [-Wmaybe-uninitialized] Yay, with a new compiler comes a new batch of false positives. :-P I'm surprised it complained at line 216 but not line 208. > Signed-off-by: Marek Vasut > Cc: Scott Wood > --- > common/cmd_nand.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/common/cmd_nand.c b/common/cmd_nand.c > index 035a6f6..b015d11 100644 > --- a/common/cmd_nand.c > +++ b/common/cmd_nand.c > @@ -191,7 +191,7 @@ static int arg_off_size(int argc, char *const argv[], int *idx, > loff_t *off, loff_t *size) > { > int ret; > - loff_t maxsize; > + loff_t maxsize = 0; > > if (argc == 0) { > *off = 0; I'll apply for next merge window. -Scott