public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] T4 U-boot: ctrl_regs.c: wr used uninitialized
Date: Mon, 26 Mar 2012 14:04:01 -0500	[thread overview]
Message-ID: <4F70BDA1.90503@freescale.com> (raw)

I get this in the T4 branch of U-Boot:

> Configuring for T4240QDS_EMU - Board: T4240QDS, Options: EMU
> ctrl_regs.c: In function 'compute_fsl_memctl_config_regs':
> ctrl_regs.c:852:15: warning: 'wr' may be used uninitialized in this function

It does not appear to be a false positive (though it is an error path),
and in any case such warnings should be squashed so that real warnings
stick out.

It was introduced by this patch:

> commit 18496c6d6cf46177e7faeb364cfe5baddb8cf71e
> Author: York Sun <yorksun@freescale.com>
> Date:   Tue Dec 13 14:16:55 2011 -0800
> 
>     powerpc/mpc8xxx: Add support for cas latency 12 and above
>     
>     Required by JEDEC 79-3E for high speed DDR3.
>     Also change "CSn disabled" message to debug.
>     
>     Signed-off-by: York Sun <yorksun@freescale.com>

I also don't see the T4 patches being posted to the mailing list -- why?

And why is there any notion of a 32-bit physical address map for T4, and
a README that suggests the 32-bit address map is used?

-Scott

             reply	other threads:[~2012-03-26 19:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 19:04 Scott Wood [this message]
2012-03-26 19:16 ` [U-Boot] T4 U-boot: ctrl_regs.c: wr used uninitialized Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F70BDA1.90503@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox