From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] spi/kirkwood: add weak functions board_spi_bus_claim/release
Date: Tue, 27 Mar 2012 15:27:50 +0200 [thread overview]
Message-ID: <4F71C056.6090302@keymile.com> (raw)
In-Reply-To: <1332755932-21259-1-git-send-email-valentin.longchamp@keymile.com>
Prafulla,
On 03/26/2012 11:58 AM, Valentin Longchamp wrote:
> Some kirkwood based boards may need to implement such function due to
> some HW designs.
I see no feedback from your side on this patch. I think you should go through
the marvell tree:
- the spi_claim/release_bus function are already implemented in the SPI subsystem
- this patch touches only a kirkwood driver
- there is no spi u-boot tree from what I see
Please keep me up to date about the status of this patch
Regards
Valentin
>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> cc: Gerlando Falauto <gerlando.falauto@keymile.com>
> cc: Prafulla Wadaskar <prafulla@marvell.com>
> cc: Holger Brunck <holger.brunck@keymile.com>
> ---
> drivers/spi/kirkwood_spi.c | 12 +++++++++++-
> 1 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index db8ba8b..058dae2 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -86,13 +86,23 @@ void spi_free_slave(struct spi_slave *slave)
> free(slave);
> }
>
> -int spi_claim_bus(struct spi_slave *slave)
> +__attribute__((weak)) int board_spi_claim_bus(struct spi_slave *slave)
> {
> return 0;
> }
>
> +int spi_claim_bus(struct spi_slave *slave)
> +{
> + return board_spi_claim_bus(slave);
> +}
> +
> +__attribute__((weak)) void board_spi_release_bus(struct spi_slave *slave)
> +{
> +}
> +
> void spi_release_bus(struct spi_slave *slave)
> {
> + board_spi_release_bus(slave);
> }
>
> #ifndef CONFIG_SPI_CS_IS_VALID
next prev parent reply other threads:[~2012-03-27 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 9:58 [U-Boot] [PATCH v2] spi/kirkwood: add weak functions board_spi_bus_claim/release Valentin Longchamp
2012-03-27 13:27 ` Valentin Longchamp [this message]
2012-03-28 7:48 ` Prafulla Wadaskar
2012-03-29 12:49 ` Valentin Longchamp
2012-03-29 14:21 ` Prafulla Wadaskar
2012-03-29 14:49 ` Valentin Longchamp
2012-03-29 15:44 ` Valentin Longchamp
2012-03-30 11:34 ` Prafulla Wadaskar
2012-03-30 12:14 ` Valentin Longchamp
2012-03-30 12:58 ` Prafulla Wadaskar
2012-04-02 13:37 ` Valentin Longchamp
2012-04-03 6:35 ` Prafulla Wadaskar
2012-04-04 7:01 ` Valentin Longchamp
2012-04-04 7:12 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71C056.6090302@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox