From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Tue, 27 Mar 2012 18:28:21 +0200 Subject: [U-Boot] [PATCH V2] fs/fat: align disk buffers on cache line to enable DMA and cache In-Reply-To: <20120327162028.39403836@wker> References: <119311> <1330897580-8931-1-git-send-email-eric.nelson@boundarydevices.com> <4F5EA1D3.8040207@boundarydevices.com> <4F6D754E.6030806@googlemail.com> <20120327162028.39403836@wker> Message-ID: <4F71EAA5.50901@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27.03.2012 16:20, Anatolij Gustschin wrote: > Hello Dirk, > > On Sat, 24 Mar 2012 08:18:38 +0100 > Dirk Behme wrote: > >> On 13.03.2012 02:24, Eric Nelson wrote: >>> On 03/04/2012 02:46 PM, Eric Nelson wrote: >>>> Signed-off-by: Eric Nelson >>>> Acked-by: Mike Frysinger >>>> --- >>>> fs/fat/fat.c | 14 ++++++++------ >>>> 1 files changed, 8 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/fs/fat/fat.c b/fs/fat/fat.c >>>> index 1f95eb4..f3c48bb 100644 >>>> --- a/fs/fat/fat.c >>>> +++ b/fs/fat/fat.c >>>> @@ -31,6 +31,8 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> +#include >>>> >>>> /* >>>> * Convert a string to lowercase. >>>> @@ -62,7 +64,7 @@ static int disk_read(__u32 block, __u32 nr_blocks, >>>> void *buf) >>>> >>>> int fat_register_device (block_dev_desc_t * dev_desc, int part_no) >>>> { >>>> - unsigned char buffer[dev_desc->blksz]; >>>> + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz); >>> > >>> >>> Hi Wolfgang, >>> >>> Have you had a chance to review this patch? Is there another >>> maintainer for fs/fat? >>> >>> Please let me know if you need this updated. >>> >>> There's another patch that was acked by Mike but is otherwise >>> lingering here: >>> >>> http://lists.denx.de/pipermail/u-boot/2012-March/119309.html >>> >>> Both of these are needed before enabling the data cache on i.MX6 when >>> using >>> the FAT filesystem. >> >> Anybody likes to comment/apply this patch? > > Both, this patch and the patch referenced by the above link were > submitted when the merge window was closed. So, the patches will > probably be applied to next when rc1 is out, unless Wolfgang > decides to accept them for coming release. Ok, thanks! Do we have a -next branch for stuff like this, then? Best regards dirk