public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] FSL/eSDHC: enable the peripheral clock to detect the card
Date: Tue, 27 Mar 2012 19:13:07 +0200	[thread overview]
Message-ID: <4F71F523.7020202@denx.de> (raw)
In-Reply-To: <1332843901-16409-1-git-send-email-Chang-Ming.Huang@freescale.com>

On 27/03/2012 12:25, Chang-Ming.Huang at freescale.com wrote:
> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> 
> According to the card detection of p1/p2 paltform RM,
> we should set SYSCTL[PEREN] to enable the clock.
> Otherwise, after booting the u-boot, and then inserting the SD card,
> the SD card can't be detected.
> 
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> CC: Andy Fleming <afleming@gmail.com>
> ---

Hi Jerry,

>  drivers/mmc/fsl_esdhc.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index a2f35e3..1682a79 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -491,6 +491,8 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
>  	/* First reset the eSDHC controller */
>  	esdhc_reset(regs);
>  
> +	esdhc_write32(&regs->sysctl, SYSCTL_PEREN);
> +

You add this setup to all architectures: PQIII, i.MX5, i.MX6. Is it what
you really want ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2012-03-27 17:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 10:25 [U-Boot] [PATCH 1/2] FSL/eSDHC: enable the peripheral clock to detect the card Chang-Ming.Huang at freescale.com
2012-03-27 10:25 ` [U-Boot] [PATCH 2/2] SDHC/MMC: remove the member has_init Chang-Ming.Huang at freescale.com
2012-04-06  8:03   ` Huang Changming-R66093
2012-05-08 22:16   ` Andy Fleming
2012-05-18  9:45     ` Huang Changming-R66093
2012-03-27 11:01 ` [U-Boot] [PATCH 1/2] FSL/eSDHC: enable the peripheral clock to detect the card Dirk Behme
2012-03-27 17:17   ` Stefano Babic
2012-03-28  3:14     ` Huang Changming-R66093
2012-03-28  8:08       ` Stefano Babic
2012-03-27 17:13 ` Stefano Babic [this message]
2012-03-28  2:23   ` Huang Changming-R66093

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F71F523.7020202@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox