From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 27 Mar 2012 19:17:08 +0200 Subject: [U-Boot] [PATCH 1/2] FSL/eSDHC: enable the peripheral clock to detect the card In-Reply-To: <4F719E27.3010001@de.bosch.com> References: <1332843901-16409-1-git-send-email-Chang-Ming.Huang@freescale.com> <4F719E27.3010001@de.bosch.com> Message-ID: <4F71F614.2080602@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27/03/2012 13:01, Dirk Behme wrote: > On 27.03.2012 12:25, Chang-Ming.Huang at freescale.com wrote: >> From: Jerry Huang >> >> According to the card detection of p1/p2 paltform RM, > > typo => platform > >> we should set SYSCTL[PEREN] to enable the clock. >> Otherwise, after booting the u-boot, and then inserting the SD card, >> the SD card can't be detected. >> >> Signed-off-by: Jerry Huang >> CC: Andy Fleming >> --- >> drivers/mmc/fsl_esdhc.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c >> index a2f35e3..1682a79 100644 >> --- a/drivers/mmc/fsl_esdhc.c >> +++ b/drivers/mmc/fsl_esdhc.c >> @@ -491,6 +491,8 @@ int fsl_esdhc_initialize(bd_t *bis, struct >> fsl_esdhc_cfg *cfg) >> /* First reset the eSDHC controller */ >> esdhc_reset(regs); >> >> + esdhc_write32(®s->sysctl, SYSCTL_PEREN); > > If I read the iMX6 manual correctly, the SYSCTL_PEREN isn't implemented > there. In the copy I could put my hands, SYSCTL_PEREN is implemented for i.MX6. However, I do not know if this has an influence. ESDHC should be clocked with SDCLKEN, that is enabled by default on i.MX (both MX5 and MX6). > So this should be a NOP for iMX6? However, if it is not implemented and it is marked as reserved, we should not set it. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================