From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 28 Mar 2012 12:26:46 +0200 Subject: [U-Boot] [PATCH 1/3] misc:pmic: Support for voltage to register value conversion function In-Reply-To: <1332924312-25600-1-git-send-email-l.majewski@samsung.com> References: <1332924312-25600-1-git-send-email-l.majewski@samsung.com> Message-ID: <4F72E766.3050503@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 28/03/2012 10:45, Lukasz Majewski wrote: > Support for voltage (in uV) to proper register value is added. > The function tied to this callback is often PMIC dependent > and shall be defined for each device. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Stefano Babic > --- Hi Lukasz, > > +int pmic_vol_to_reg(struct pmic *p, int uV) You added a new entry point to pmic, but you do not use it...I have not found in your patchset why it is necessary for you. I am not sure if we require to add this to the PMIC API or hide in the pmic specific code. Other PMICs has not a a register for different voltages, but only a bit inside the same register (this is the case for the Freescale's PMICs we currently support in u-boot). Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================