From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 28 Mar 2012 14:50:35 +0200 Subject: [U-Boot] [PATCH 1/3] misc:pmic: Support for voltage to register value conversion function In-Reply-To: <20120328143820.44ca652c@lmajewski.digital.local> References: <1332924312-25600-1-git-send-email-l.majewski@samsung.com> <4F72E766.3050503@denx.de> <20120328132606.7537d9c6@lmajewski.digital.local> <4F72F8F2.3070109@denx.de> <20120328143820.44ca652c@lmajewski.digital.local> Message-ID: <4F73091B.4000708@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 28/03/2012 14:38, Lukasz Majewski wrote: > Hi Stefano, > Hi Lucasz, > I've already forwarded those patches to you. > They are also available on the mailing list, so I don't know what has > happened. Really nothing, I got all e-mails, I was only not able to explain my doubt. I try again: - In patch 1/3 you add voltage_to_reg to the pmic struct ==> Ok - in patch 2/3 you add voltage_to_reg to MAX8997. ==> Ok Everything clear. The consequence for me is that PATCH 3/3 shows the reason to add voltage_to_reg(), and calls the new function pmic_vol_to_reg(), because you need it, as you have already explained. But I see only pmic_set_output() and pmic_reg_write() in your patch. What have I not yet understood ? (maybe I need a coffe to wake up my brain...) Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================