From mboxrd@z Thu Jan  1 00:00:00 1970
From: Graeme Russ <graeme.russ@gmail.com>
Date: Sun, 01 Apr 2012 21:25:03 +1000
Subject: [U-Boot] [PATCH V6] BOOT: Add "bootz" command to boot Linux
 zImage on ARM
In-Reply-To: <201203312127.44952.marex@denx.de>
References: <Message-Id: <1331696876-20903-1-git-send-email-marex@denx.de>
	<1331797965-7415-1-git-send-email-marex@denx.de>
	<201203311510.57082.vapier@gentoo.org>
	<201203312127.44952.marex@denx.de>
Message-ID: <4F783B0F.9010504@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On 04/01/2012 05:27 AM, Marek Vasut wrote:
> Dear Mike Frysinger,
> 
>> On Thursday 15 March 2012 03:52:45 Marek Vasut wrote:
>>> --- a/common/cmd_bootm.c
>>> +++ b/common/cmd_bootm.c
>>>
>>> -static void bootm_start_lmb(void)
>>> -{
>>>
>>>  #ifdef CONFIG_LMB
>>>
>>> +static void boot_start_lmb(bootm_headers_t *images)
>>> +{
>>>
>>>  	ulong		mem_start;
>>>  	phys_size_t	mem_size;
>>>
>>> -	lmb_init(&images.lmb);
>>> +	lmb_init(&images->lmb);
>>>
>>>  	mem_start = getenv_bootm_low();
>>>  	mem_size = getenv_bootm_size();
>>>
>>> -	lmb_add(&images.lmb, (phys_addr_t)mem_start, mem_size);
>>> +	lmb_add(&images->lmb, (phys_addr_t)mem_start, mem_size);
>>>
>>> -	arch_lmb_reserve(&images.lmb);
>>> -	board_lmb_reserve(&images.lmb);
>>> +	arch_lmb_reserve(&images->lmb);
>>> +	board_lmb_reserve(&images->lmb);
>>> +}
>>>
>>>  #else
>>>
>>> -# define lmb_reserve(lmb, base, size)
>>> +static inline void boot_start_lmb(bootm_headers_t *images) { }
>>>
>>>  #endif
>>>
>>> -}
>>
>> this breaks all non-lmb configs.  before, lmb_reverse() was stubbed out,
>> but now it's not, leading to build failures:
>>
>> cmd_bootm.c: In function ?do_bootm_subcommand?:
>> cmd_bootm.c:518:23: error: ?bootm_headers_t? has no member named ?lmb?
>> cmd_bootm.c: In function ?do_bootm?:
>> cmd_bootm.c:665:21: error: ?bootm_headers_t? has no member named ?lmb?
>> make[2]: *** [cmd_bootm.o] Error 1
>> -mike
> 
> Well tested on arm/ppc ... can you submit patch for these platforms please ?

I think the 'You Break, You Fix' rule applies ;)

> I'll be able to run mips/x86 next week.

Dang, I need it building now :P

I'm going to but in some really dodgy hacks just to get my build going
again, but I would appreciate a fix ASAP

Regards,

Graeme