[U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses

Marek Vasut
2012-04-02T18:42:48Z

Dear Mike Frysinger,

> On Mon, Apr 2, 2012 at 12:18, Stefano Babic wrote:
> > Misaligned warnings are useful to debug faulty drivers.
> > A misaligned warning is printed also when the driver
> > is correct - use debug() instead of printf().
>
> unfortunately, this turns the failure into a silent one. if i read
> the code correctly, you still return an error in this code path which
> means things don't actually get flushed/invalidated.

You certainly do return an error, yes. And you don't do the op ... but then,
what's the whole point of this check?

You can just ignore the return value in the flush() op, but I still don't like
how this is ignored.

> to the original concept, i have no problem with cache funcs all
> warning on misalignment via debug() so developers can quickly see if
> things need to be reviewed.
> -mike

Best regards,
Marek Vasut