[U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses

Mike Frysinger
2012-04-02T19:07:31Z

On Mon, Apr 2, 2012 at 14:42, Marek Vasut wrote:
>> On Mon, Apr 2, 2012 at 12:18, Stefano Babic wrote:
>> > Misaligned warnings are useful to debug faulty drivers.
>> > A misaligned warning is printed also when the driver
>> > is correct - use debug() instead of printf().
>>
>> unfortunately, this turns the failure into a silent one. ?if i read
>> the code correctly, you still return an error in this code path which
>> means things don't actually get flushed/invalidated.
>
> You certainly do return an error, yes. And you don't do the op ...
>
> You can just ignore the return value in the flush() op, but I still don't like
> how this is ignored.

this is all internal to this soc's cache code. the common API
provides no support for returning an "error" because there is no such
thing with these funcs. you do the operation on the region requested
regardless of implicit side-effects.

> but then, what's the whole point of this check?

my point all along :p
-mike