From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Mon, 02 Apr 2012 20:18:10 +0200 Subject: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules In-Reply-To: <7605B15734F74B40A124AED46B25250A4F2809@HEFRMBX01.sofr.hefr.lan> References: <7605B15734F74B40A124AED46B25250A4F257F@HEFRMBX01.sofr.hefr.lan> <201204012302.05768.marex@denx.de> <7605B15734F74B40A124AED46B25250A4F26AD@HEFRMBX01.sofr.hefr.lan> <201204021539.06044.marex@denx.de> <7605B15734F74B40A124AED46B25250A4F2809@HEFRMBX01.sofr.hefr.lan> Message-ID: <4F79ED62.5040303@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 02/04/2012 19:47, schrieb Gachet Daniel: > Hi Stefano, > > Have I to do more for the patch? Are you ok with the proposal? > That is ok. Please use a shorter name: the function you patch is already surrounded by #ifdef MXC_NFC_V1_1, so it is not required to repeat it in the name (we have a lot of long names, but CONFIG_NAND_MXC_V1_1_NFC_ONE_CYCLE is really quite long). The name suggest also that you want to set ONE_CYCLE, but really you want the opposite. Something like CONFIG_NAND_MXC_NO_ONE_CYLE is still long, but maybe more correct. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================