From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cm-t35: add I2C multi-bus support
Date: Tue, 03 Apr 2012 09:09:01 +0300 [thread overview]
Message-ID: <4F7A93FD.5050009@compulab.co.il> (raw)
In-Reply-To: <4F79B54C.9050008@ti.com>
Hi Tom,
On 04/02/12 17:18, Tom Rini wrote:
> On 04/02/2012 05:29 AM, Igor Grinberg wrote:
>> From: Nikita Kiryanov<nikita@compulab.co.il>
>>
>> Enable I2C multi-bus support and config I2C muxes for I2C2 and I2C3.
>>
>> Signed-off-by: Nikita Kiryanov<nikita@compulab.co.il>
>> Signed-off-by: Igor Grinberg<grinberg@compulab.co.il>
>
> Have you confirmed this is sufficient and there's no changes required in omap24xx_i2c.c ? Thanks!
I don't know what do you mean by sufficient...
I've tested this patch on bus 0 and 2 by reading/writing to eeproms and
it is working fine, so IMO it is sufficient.
Some time ago, I've seen a problem with Ethernet initialization
and tracked it down to:
0607e2b ARMV7: OMAP: Write more than 1 byte at a time in i2c_write
cm-t35 and cm-t3730 have Ethernet reset signal wired to TPS65930 GPIO,
so I2C transaction is needed to reset the Ethernet.
So my conclusion was that the commit above changed the timings and
that broke the Ethernet reset code.
After examining the Ethernet reset code, the fix was obvious,
as the reset code had wrong timing for the reset pulse.
So I've fixed this locally, but forgot to send a patch.
Sending in a moment...
--
Regards,
Igor.
next prev parent reply other threads:[~2012-04-03 6:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 12:29 [U-Boot] [PATCH] cm-t35: add I2C multi-bus support Igor Grinberg
2012-04-02 14:18 ` Tom Rini
2012-04-03 6:09 ` Igor Grinberg [this message]
2012-04-03 16:20 ` Tom Rini
2012-04-20 17:27 ` Tom Rini
2012-04-22 6:09 ` Igor Grinberg
2012-04-23 15:05 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7A93FD.5050009@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox