From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole
Date: Tue, 03 Apr 2012 22:54:23 +0200 [thread overview]
Message-ID: <4F7B637F.2080203@linutronix.de> (raw)
In-Reply-To: <201204031642.24521.vapier@gentoo.org>
On 04/03/2012 10:42 PM, Mike Frysinger wrote:
> On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote:
>> --- a/drivers/net/tsec.c
>> +++ b/drivers/net/tsec.c
>>
>> + if (strcmp(getenv("stdout"), "nc"))
>
> i really don't like special casing devices like this
>
>> - serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
>> - (phydev->duplex) ? "full" : "half",
>> - (phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
>> + serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
>> + (phydev->duplex) ? "full" : "half",
>> + (phydev->port == PORT_FIBRE) ? ", fiber mode"
>> + : "");
>
> why not just delete this line completely ?
*I* don't mind but others might complain about missing important
information. So in my re-do of the series I remove it instead and see
what happens.
> -mike
Sebastian
next prev parent reply other threads:[~2012-04-03 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 20:11 [U-Boot] [PATCH 1/3] net/eth: set status to active before calling init Sebastian Andrzej Siewior
2012-03-23 20:11 ` [U-Boot] [PATCH 2/3] net/tsec: convert the printf() to serial_printf() Sebastian Andrzej Siewior
2012-03-23 20:11 ` [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole Sebastian Andrzej Siewior
2012-04-03 20:42 ` Mike Frysinger
2012-04-03 20:54 ` Sebastian Andrzej Siewior [this message]
2012-04-04 15:27 ` Joe Hershberger
2012-04-08 8:26 ` Mike Frysinger
2012-04-09 21:43 ` Joe Hershberger
2012-04-03 20:41 ` [U-Boot] [PATCH 1/3] net/eth: set status to active before calling init Mike Frysinger
2012-04-03 20:51 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B637F.2080203@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox