From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Tue, 03 Apr 2012 22:54:23 +0200
Subject: [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if
 used with netconsole
In-Reply-To: <201204031642.24521.vapier@gentoo.org>
References: <1332533480-19121-1-git-send-email-bigeasy@linutronix.de>
	<1332533480-19121-3-git-send-email-bigeasy@linutronix.de>
	<201204031642.24521.vapier@gentoo.org>
Message-ID: <4F7B637F.2080203@linutronix.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/03/2012 10:42 PM, Mike Frysinger wrote:
> On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote:
>> --- a/drivers/net/tsec.c
>> +++ b/drivers/net/tsec.c
>>
>> +	if (strcmp(getenv("stdout"), "nc"))
>
> i really don't like special casing devices like this
>
>> -	serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
>> -			(phydev->duplex) ? "full" : "half",
>> -			(phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
>> +		serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
>> +				(phydev->duplex) ? "full" : "half",
>> +				(phydev->port == PORT_FIBRE) ? ", fiber mode"
>> +				: "");
>
> why not just delete this line completely ?

*I* don't mind but others might complain about missing important
information. So in my re-do of the series I remove it instead and see
what happens.

> -mike

Sebastian