[U-Boot] [PATCH 1/3] imx: Add GPIO_TO_PORT macro

[Stefano Babic <sbabic@denx.de>]

On 04/04/2012 18:05, Vikram Narayanan wrote:
> imx: Add GPIO_TO_PORT macro
> 
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>

Hi,

> ---
>  arch/arm/include/asm/arch-mx5/gpio.h |    2 ++
>  arch/arm/include/asm/arch-mx6/gpio.h |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
>   50.0% arch/arm/include/asm/arch-mx5/
>   50.0% arch/arm/include/asm/arch-mx6/
> 
> diff --git a/arch/arm/include/asm/arch-mx5/gpio.h b/arch/arm/include/asm/arch-mx5/gpio.h
> index 1dc34e9..bcb5edb 100644
> --- a/arch/arm/include/asm/arch-mx5/gpio.h
> +++ b/arch/arm/include/asm/arch-mx5/gpio.h
> @@ -25,6 +25,8 @@
>  #ifndef __ASM_ARCH_MX5_GPIO_H
>  #define __ASM_ARCH_MX5_GPIO_H
>  
> +#define GPIO_TO_PORT(number)		(number/32)
> +
>  /* GPIO registers */
>  struct gpio_regs {
>  	u32	gpio_dr;
> diff --git a/arch/arm/include/asm/arch-mx6/gpio.h b/arch/arm/include/asm/arch-mx6/gpio.h
> index 20c4e57..385d12d 100644
> --- a/arch/arm/include/asm/arch-mx6/gpio.h
> +++ b/arch/arm/include/asm/arch-mx6/gpio.h
> @@ -25,6 +25,8 @@
>  #ifndef __ASM_ARCH_MX6_GPIO_H
>  #define __ASM_ARCH_MX6_GPIO_H
>  
> +#define GPIO_TO_PORT(number)		(number/32)
> +
>  /* GPIO registers */
>  struct gpio_regs {
>  	u32	gpio_dr;

NAK. We have already (and probably too many) GPIO_TO_PORT:

arch/arm/include/asm/arch-mx6/imx-regs.h:#define GPIO_TO_PORT(number)	
(((number)/32)+1)
arch/arm/include/asm/arch-mx5/mx5x_pins.h:#define GPIO_TO_PORT(n)
  (n / GPIO_NUM_PIN)

Are they not enough ?

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================