public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: puneets <puneets@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9] usb: align buffers at cacheline
Date: Fri, 6 Apr 2012 16:24:30 +0530	[thread overview]
Message-ID: <4F7ECB66.3070603@nvidia.com> (raw)
In-Reply-To: <201204041001.46847.marex@denx.de>

Hi Marek,
I tested on tegra2, Seaboard and didn't see these messages though see 
lots of messages
"ERROR: v7_dcache_inval_range - stop address is not aligned - 
0x3fb7c608" which are expected.
PFA the logs if you can make out anything useful.

Try to increase the delay in handshake();

Thanks,
Puneet

On Wednesday 04 April 2012 01:31 PM, Marek Vasut wrote:
> Dear Puneet Saxena,
>
>> This avoids cache-alignment warnings shown in console
>> when a usb command is entered.
>>
>> Whenever X bytes of unaligned buffer is invalidated, arm core
>> invalidates X + Y bytes as per the cache line size and throws
>> these warnings.
>>
>> Signed-off-by: Puneet Saxena<puneets@nvidia.com>
>> ---
> I think we're almost there, hurray! :-)
>
> Though on m28evk this still has issues:
>
> =>  usb reset
> (Re)start USB...
> USB:   Register 10011 NbrPorts 1
> USB EHCI 1.00
> scanning bus for devices... EHCI timed out on TD - token=0x80008c80
> EHCI timed out on TD - token=0x80008d80
> EHCI timed out on TD - token=0x80008c80
> EHCI timed out on TD - token=0x80008c80
> EHCI timed out on TD - token=0x80008c80
>   ERROR: NOT USB_CONFIG_DESC 1
> EHCI timed out on TD - token=0x80008d80
> 2 USB Device(s) found
>         scanning bus for storage devices... 0 Storage Device(s) found
>
> I have a single USB pendrive connected to the board.
>
> Also note, that if I disable the caches, it all works even with your patch
> applied. So I suspect there's something even more to this (maybe broken
> ehci_invalidate_dcache() ? ). Where did you test these patches?
>
> Thanks!
>
> Best regards,
> Marek Vasut


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pendrive_prints.txt
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120406/e74c5949/attachment.txt>

      reply	other threads:[~2012-04-06 10:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03  9:26 [U-Boot] [PATCH v9] usb: align buffers at cacheline Puneet Saxena
2012-04-04  8:01 ` Marek Vasut
2012-04-06 10:54   ` puneets [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7ECB66.3070603@nvidia.com \
    --to=puneets@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox