From: Vikram Narayanan <vikram186@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] imx: Add GPIO_TO_PORT macro
Date: Mon, 09 Apr 2012 20:00:32 +0530 [thread overview]
Message-ID: <4F82F288.80603@gmail.com> (raw)
In-Reply-To: <4F8274BE.1030507@googlemail.com>
Hello Dirk,
On 4/9/2012 11:03 AM, Dirk Behme wrote:
> Dear Vikram ,
>
> On 06.04.2012 10:56, Stefano Babic wrote:
>> On 04/04/2012 18:05, Vikram Narayanan wrote:
>>> imx: Add GPIO_TO_PORT macro
>>>
>>> Signed-off-by: Vikram Narayanan<vikram186@gmail.com>
>>
>> Hi,
>>
>>> ---
>>> arch/arm/include/asm/arch-mx5/gpio.h | 2 ++
>>> arch/arm/include/asm/arch-mx6/gpio.h | 2 ++
>>> 2 files changed, 4 insertions(+), 0 deletions(-)
>>> 50.0% arch/arm/include/asm/arch-mx5/
>>> 50.0% arch/arm/include/asm/arch-mx6/
>>>
>>> diff --git a/arch/arm/include/asm/arch-mx5/gpio.h
>>> b/arch/arm/include/asm/arch-mx5/gpio.h
>>> index 1dc34e9..bcb5edb 100644
>>> --- a/arch/arm/include/asm/arch-mx5/gpio.h
>>> +++ b/arch/arm/include/asm/arch-mx5/gpio.h
>>> @@ -25,6 +25,8 @@
>>> #ifndef __ASM_ARCH_MX5_GPIO_H
>>> #define __ASM_ARCH_MX5_GPIO_H
>>>
>>> +#define GPIO_TO_PORT(number) (number/32)
>>> +
>>> /* GPIO registers */
>>> struct gpio_regs {
>>> u32 gpio_dr;
>>> diff --git a/arch/arm/include/asm/arch-mx6/gpio.h
>>> b/arch/arm/include/asm/arch-mx6/gpio.h
>>> index 20c4e57..385d12d 100644
>>> --- a/arch/arm/include/asm/arch-mx6/gpio.h
>>> +++ b/arch/arm/include/asm/arch-mx6/gpio.h
>>> @@ -25,6 +25,8 @@
>>> #ifndef __ASM_ARCH_MX6_GPIO_H
>>> #define __ASM_ARCH_MX6_GPIO_H
>>>
>>> +#define GPIO_TO_PORT(number) (number/32)
>>> +
>>> /* GPIO registers */
>>> struct gpio_regs {
>>> u32 gpio_dr;
>>
>> NAK. We have already (and probably too many) GPIO_TO_PORT:
>>
>> arch/arm/include/asm/arch-mx6/imx-regs.h:#define GPIO_TO_PORT(number)
>> (((number)/32)+1)
>> arch/arm/include/asm/arch-mx5/mx5x_pins.h:#define GPIO_TO_PORT(n)
>> (n / GPIO_NUM_PIN)
>>
>> Are they not enough ?
@Stefano: Yeah. Just didn't notice it. Will resend it.
> Vikram, it seems to me you sent the already NAKed patch to me
>
> https://github.com/dirkbehme/u-boot-imx6/pull/2
>
> again?
>
Sorry, something went wrong with my filter settings in my mailbox. I
wasn't aware that it got NACked. Sorry for sending a pull req anyways.
> Please send U-Boot patches only to this U-Boot mailing list.
Sure. From now on!
> Dirk
~Vikram
next prev parent reply other threads:[~2012-04-09 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 16:05 [U-Boot] [PATCH 1/3] imx: Add GPIO_TO_PORT macro Vikram Narayanan
2012-04-06 8:56 ` Stefano Babic
2012-04-09 5:33 ` Dirk Behme
2012-04-09 14:30 ` Vikram Narayanan [this message]
2012-04-09 16:09 ` Vikram Narayanan
2012-04-09 22:31 ` stefano babic
2012-04-10 2:47 ` Vikram Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F82F288.80603@gmail.com \
--to=vikram186@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox