[U-Boot] [PATCH V2] MX35: mx35pdk: wrong board revision

[Stefano Babic <sbabic@denx.de>]

On 09/04/2012 14:56, Fabio Estevam wrote:
> On 4/9/12, Stefano Babic <sbabic@denx.de> wrote:
>> The board revision is detected accessing to the pmic,
>> that is not available before relocation (I2C).
>> This generates the following error:
>>
>> CPU:   Freescale i.MX35 rev 2.0 at 532 MHz.
>> Reset cause: WDOG
>> <reg num> = 7 is invalid. Should be less than 0
>> Board: MX35 PDK 1.0
>>
>> The revision number is wrong, as a default value is printed
>> (tested on a mx35pdk Rev. 2.0).
>>
>> Move the output in the board_late_init(), when
>> pmic can be accessed.
>>
>> Signed-off-by: Stefano Babic <sbabic@denx.de>
>> ---
>>
>> V2: drop dead code
>>
>>  board/freescale/mx35pdk/mx35pdk.c |   11 -----------
>>  include/configs/mx35pdk.h         |    1 -
>>  2 files changed, 0 insertions(+), 12 deletions(-)
> 

Hi Fabio,

> Looks like there is something wrong with this patch: 12 deletions and
> no insertions.
> 
> Comparing it with v1 I would expect that only the "#if 0 and #endif"
> were removed.

At first glance, yes. However, the patch produces the correct code. The
checkboard function is removed, but not completely, and its last two
statements (printf and return) slip into the board_late_init() function,
where the i2c is already initialized and pmic already used.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================