* [U-Boot] [PATCH v2 3/4] imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5)
@ 2012-04-10 14:26 Vikram Narayanan
2012-04-10 14:44 ` Stefano Babic
2012-04-11 7:33 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Vikram Narayanan @ 2012-04-10 14:26 UTC (permalink / raw)
To: u-boot
Use the defined GPIO_TO_PORT macro. Remove gpio >> 5 references.
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
---
drivers/gpio/mxc_gpio.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
index 7e65b39..21b1cdc 100644
--- a/drivers/gpio/mxc_gpio.c
+++ b/drivers/gpio/mxc_gpio.c
@@ -54,7 +54,7 @@ static unsigned long gpio_ports[] = {
static int mxc_gpio_direction(unsigned int gpio,
enum mxc_gpio_direction direction)
{
- unsigned int port = gpio >> 5;
+ unsigned int port = GPIO_TO_PORT(gpio);
struct gpio_regs *regs;
u32 l;
@@ -81,7 +81,7 @@ static int mxc_gpio_direction(unsigned int gpio,
int gpio_set_value(unsigned gpio, int value)
{
- unsigned int port = gpio >> 5;
+ unsigned int port = GPIO_TO_PORT(gpio);
struct gpio_regs *regs;
u32 l;
@@ -104,7 +104,7 @@ int gpio_set_value(unsigned gpio, int value)
int gpio_get_value(unsigned gpio)
{
- unsigned int port = gpio >> 5;
+ unsigned int port = GPIO_TO_PORT(gpio);
struct gpio_regs *regs;
u32 val;
@@ -122,7 +122,7 @@ int gpio_get_value(unsigned gpio)
int gpio_request(unsigned gpio, const char *label)
{
- unsigned int port = gpio >> 5;
+ unsigned int port = GPIO_TO_PORT(gpio);
if (port >= ARRAY_SIZE(gpio_ports))
return -1;
return 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 3/4] imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5)
2012-04-10 14:26 [U-Boot] [PATCH v2 3/4] imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5) Vikram Narayanan
@ 2012-04-10 14:44 ` Stefano Babic
2012-04-11 7:33 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-04-10 14:44 UTC (permalink / raw)
To: u-boot
On 10/04/2012 16:26, Vikram Narayanan wrote:
> Use the defined GPIO_TO_PORT macro. Remove gpio >> 5 references.
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> ---
> drivers/gpio/mxc_gpio.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
> index 7e65b39..21b1cdc 100644
> --- a/drivers/gpio/mxc_gpio.c
> +++ b/drivers/gpio/mxc_gpio.c
> @@ -54,7 +54,7 @@ static unsigned long gpio_ports[] = {
> static int mxc_gpio_direction(unsigned int gpio,
> enum mxc_gpio_direction direction)
> {
> - unsigned int port = gpio >> 5;
> + unsigned int port = GPIO_TO_PORT(gpio);
> struct gpio_regs *regs;
> u32 l;
>
> @@ -81,7 +81,7 @@ static int mxc_gpio_direction(unsigned int gpio,
>
> int gpio_set_value(unsigned gpio, int value)
> {
> - unsigned int port = gpio >> 5;
> + unsigned int port = GPIO_TO_PORT(gpio);
> struct gpio_regs *regs;
> u32 l;
>
> @@ -104,7 +104,7 @@ int gpio_set_value(unsigned gpio, int value)
>
> int gpio_get_value(unsigned gpio)
> {
> - unsigned int port = gpio >> 5;
> + unsigned int port = GPIO_TO_PORT(gpio);
> struct gpio_regs *regs;
> u32 val;
>
> @@ -122,7 +122,7 @@ int gpio_get_value(unsigned gpio)
>
> int gpio_request(unsigned gpio, const char *label)
> {
> - unsigned int port = gpio >> 5;
> + unsigned int port = GPIO_TO_PORT(gpio);
> if (port >= ARRAY_SIZE(gpio_ports))
> return -1;
> return 0;
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 3/4] imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5)
2012-04-10 14:26 [U-Boot] [PATCH v2 3/4] imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5) Vikram Narayanan
2012-04-10 14:44 ` Stefano Babic
@ 2012-04-11 7:33 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-04-11 7:33 UTC (permalink / raw)
To: u-boot
On 10/04/2012 16:26, Vikram Narayanan wrote:
> Use the defined GPIO_TO_PORT macro. Remove gpio >> 5 references.
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> ---
Applied to u-boot-imx (fix), thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-11 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-10 14:26 [U-Boot] [PATCH v2 3/4] imx: Use GPIO_TO_PORT macro in the gpio driver instead of (gpio >> 5) Vikram Narayanan
2012-04-10 14:44 ` Stefano Babic
2012-04-11 7:33 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox