* [U-Boot] [PATCH v2 4/4] imx: Return gpio_set_value in gpio_direction_output
@ 2012-04-10 14:26 Vikram Narayanan
2012-04-10 14:44 ` Stefano Babic
2012-04-11 7:33 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Vikram Narayanan @ 2012-04-10 14:26 UTC (permalink / raw)
To: u-boot
Return gpio_set_value in gpio_direction_output.
Earlier it returned 0 and ignored gpio_set_value's return value.
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
---
drivers/gpio/mxc_gpio.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
index 21b1cdc..f1b1c16 100644
--- a/drivers/gpio/mxc_gpio.c
+++ b/drivers/gpio/mxc_gpio.c
@@ -145,6 +145,5 @@ int gpio_direction_output(unsigned gpio, int value)
if (ret < 0)
return ret;
- gpio_set_value(gpio, value);
- return 0;
+ return gpio_set_value(gpio, value);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 4/4] imx: Return gpio_set_value in gpio_direction_output
2012-04-10 14:26 [U-Boot] [PATCH v2 4/4] imx: Return gpio_set_value in gpio_direction_output Vikram Narayanan
@ 2012-04-10 14:44 ` Stefano Babic
2012-04-11 7:33 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-04-10 14:44 UTC (permalink / raw)
To: u-boot
On 10/04/2012 16:26, Vikram Narayanan wrote:
> Return gpio_set_value in gpio_direction_output.
> Earlier it returned 0 and ignored gpio_set_value's return value.
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> ---
> drivers/gpio/mxc_gpio.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
> index 21b1cdc..f1b1c16 100644
> --- a/drivers/gpio/mxc_gpio.c
> +++ b/drivers/gpio/mxc_gpio.c
> @@ -145,6 +145,5 @@ int gpio_direction_output(unsigned gpio, int value)
> if (ret < 0)
> return ret;
>
> - gpio_set_value(gpio, value);
> - return 0;
> + return gpio_set_value(gpio, value);
> }
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 4/4] imx: Return gpio_set_value in gpio_direction_output
2012-04-10 14:26 [U-Boot] [PATCH v2 4/4] imx: Return gpio_set_value in gpio_direction_output Vikram Narayanan
2012-04-10 14:44 ` Stefano Babic
@ 2012-04-11 7:33 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-04-11 7:33 UTC (permalink / raw)
To: u-boot
On 10/04/2012 16:26, Vikram Narayanan wrote:
> Return gpio_set_value in gpio_direction_output.
> Earlier it returned 0 and ignored gpio_set_value's return value.
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> ---
Applied to u-boot-imx (fix), thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-11 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-10 14:26 [U-Boot] [PATCH v2 4/4] imx: Return gpio_set_value in gpio_direction_output Vikram Narayanan
2012-04-10 14:44 ` Stefano Babic
2012-04-11 7:33 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox