public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.mx: i.mx6x: NO_MUX_I/NO_PAD_I not set correctly
Date: Wed, 11 Apr 2012 13:58:33 +0200	[thread overview]
Message-ID: <4F8571E9.2080000@denx.de> (raw)
In-Reply-To: <1334143082-7876-1-git-send-email-jason.hui@linaro.org>

On 11/04/2012 13:18, Jason Liu wrote:
> If one PAD does not have mux or pad config register, we need
> set the NO_MUX_I/NO_PAD_I to 0, the old value is not correct
> 
> Signed-off-by: Jason Liu <jason.hui@linaro.org>
> CC: Stefano Babic <sbabic@denx.de>
> ---
>  arch/arm/include/asm/arch-mx6/mx6x_pins.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-mx6/mx6x_pins.h b/arch/arm/include/asm/arch-mx6/mx6x_pins.h
> index afaa068..9979651 100644
> --- a/arch/arm/include/asm/arch-mx6/mx6x_pins.h
> +++ b/arch/arm/include/asm/arch-mx6/mx6x_pins.h
> @@ -48,8 +48,8 @@
>  #define PAD_CTL_SRE_FAST	(1 << 0)
>  #define PAD_CTL_SRE_SLOW	(0 << 0)
>  
> -#define NO_MUX_I		0x3FF
> -#define NO_PAD_I		0x7FF
> +#define NO_MUX_I                0
> +#define NO_PAD_I                0
>  
>  enum {
>  	MX6Q_PAD_SD2_DAT1__USDHC2_DAT1		= IOMUX_PAD(0x0360, 0x004C, 0, 0x0000, 0, 0),

Agree. Please correct me if I am wrong, but with these changes we should
sure that the iomux register are not set if we do not want, because in
imx_iomux_v3_setup_pad:

if (sel_input_ofs)
	__raw_writel(sel_input, base + sel_input_ofs);

and NO_MUX_I = 0 should set sel_input_ofs to 0.

It is then difficult to understand why we have up now 0x3FF as value,
but it neverminds..

Acked-by: Stefano Babic <sbabic@denx.de>

(This is a fix, I will merge it for the release)

Best regards,
Stefano Babic
-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2012-04-11 11:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 11:18 [U-Boot] [PATCH] i.mx: i.mx6x: NO_MUX_I/NO_PAD_I not set correctly Jason Liu
2012-04-11 11:58 ` Stefano Babic [this message]
2012-05-15 12:42   ` Dirk Behme
2012-06-12 17:05 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8571E9.2080000@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox