From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2 V3] DMA: Split the APBH DMA init into block and channel init
Date: Wed, 11 Apr 2012 16:14:49 +0200 [thread overview]
Message-ID: <4F8591D9.5020700@denx.de> (raw)
In-Reply-To: <1333942486-14480-1-git-send-email-marex@denx.de>
On 09/04/2012 05:34, Marek Vasut wrote:
> This fixes the issue where mxs_dma_init() was called either twice or never,
> without introducing any new init hooks.
>
> The idea is to allow each and every device using the APBH DMA block to
> configure and request only the channels it uses, instead of making it call init
> for all the channels as is now.
>
> The common DMA block init part, which only configures the block, is then called
> from CPUs arch_cpu_init() call.
>
> NOTE: This patch depends on:
>
> http://patchwork.ozlabs.org/patch/150957/
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Detlev Zundel <dzu@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> ---
After fixing the following checkpatch errors:
ERROR: open brace '{' following function declarations go on the next line
#120: FILE: drivers/dma/apbh_dma.c:579:
+int mxs_dma_init_channel(int channel) {
ERROR: that open brace { should be on the previous line
#195: FILE: drivers/mtd/nand/mxs_nand.c:1076:
+ for (j = MXS_DMA_CHANNEL_AHB_APBH_GPMI0;
+ j <= MXS_DMA_CHANNEL_AHB_APBH_GPMI7; j++)
+ {
total: 2 errors, 0 warnings, 137 lines checked
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
next prev parent reply other threads:[~2012-04-11 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 3:09 [U-Boot] [PATCH 0/2] i.MX28: DMA fixups Marek Vasut
2012-04-09 3:09 ` [U-Boot] [PATCH 1/2] DMA: Split the APBH DMA init into block and channel init Marek Vasut
2012-04-09 3:28 ` [U-Boot] [PATCH 1/2 V2] " Marek Vasut
2012-04-09 3:34 ` [U-Boot] [PATCH 1/2 V3] " Marek Vasut
2012-04-09 14:10 ` Fabio Estevam
2012-04-11 14:14 ` Stefano Babic [this message]
2012-04-09 3:09 ` [U-Boot] [PATCH 2/2] M28: Pull out CONFIG_APBH_DMA so it's always enabled Marek Vasut
2012-04-11 14:15 ` Stefano Babic
2012-04-09 3:11 ` [U-Boot] [PATCH 0/2] i.MX28: DMA fixups Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8591D9.5020700@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox