From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 11 Apr 2012 16:14:49 +0200 Subject: [U-Boot] [PATCH 1/2 V3] DMA: Split the APBH DMA init into block and channel init In-Reply-To: <1333942486-14480-1-git-send-email-marex@denx.de> References: <1333942107-27045-1-git-send-email-marex@denx.de> <1333942486-14480-1-git-send-email-marex@denx.de> Message-ID: <4F8591D9.5020700@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/04/2012 05:34, Marek Vasut wrote: > This fixes the issue where mxs_dma_init() was called either twice or never, > without introducing any new init hooks. > > The idea is to allow each and every device using the APBH DMA block to > configure and request only the channels it uses, instead of making it call init > for all the channels as is now. > > The common DMA block init part, which only configures the block, is then called > from CPUs arch_cpu_init() call. > > NOTE: This patch depends on: > > http://patchwork.ozlabs.org/patch/150957/ > > Signed-off-by: Marek Vasut > Cc: Stefano Babic > Cc: Wolfgang Denk > Cc: Detlev Zundel > Cc: Fabio Estevam > --- After fixing the following checkpatch errors: ERROR: open brace '{' following function declarations go on the next line #120: FILE: drivers/dma/apbh_dma.c:579: +int mxs_dma_init_channel(int channel) { ERROR: that open brace { should be on the previous line #195: FILE: drivers/mtd/nand/mxs_nand.c:1076: + for (j = MXS_DMA_CHANNEL_AHB_APBH_GPMI0; + j <= MXS_DMA_CHANNEL_AHB_APBH_GPMI7; j++) + { total: 2 errors, 0 warnings, 137 lines checked Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================