public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qsabrelite: No need to set the direction for GPIO3_23 again
Date: Thu, 12 Apr 2012 19:53:43 +0200	[thread overview]
Message-ID: <4F8716A7.1050606@googlemail.com> (raw)
In-Reply-To: <1334175744-26707-1-git-send-email-festevam@gmail.com>

On 11.04.2012 22:22, Fabio Estevam wrote:
> There is a 'gpio_direction_output(87, 0);' call previously, so the GPIO direction is
> already established.
>
> Use gpio_set_value() for changing the GPIO output then.
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
>   board/freescale/mx6qsabrelite/mx6qsabrelite.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 1d09a72..2155d87 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -135,7 +135,7 @@ static void setup_iomux_enet(void)
>
>   	/* Need delay 10ms according to KSZ9021 spec */
>   	udelay(1000 * 10);
> -	gpio_direction_output(87, 1);  /* GPIO 3-23 */
> +	gpio_set_value(87, 1);  /* GPIO 3-23 */
>
>   	imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
>   }

Acked-by: Dirk Behme <dirk.behme@googlemail.com>

Thanks

Dirk

  reply	other threads:[~2012-04-12 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 20:22 [U-Boot] [PATCH] mx6qsabrelite: No need to set the direction for GPIO3_23 again Fabio Estevam
2012-04-12 17:53 ` Dirk Behme [this message]
2012-04-23  9:48 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8716A7.1050606@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox