From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/7] tegra: fdt: Add NAND controller binding and definitions
Date: Fri, 13 Apr 2012 16:21:40 -0500 [thread overview]
Message-ID: <4F8898E4.4000505@freescale.com> (raw)
In-Reply-To: <4F88937D.3090809@wwwdotorg.org>
On 04/13/2012 03:58 PM, Stephen Warren wrote:
> On 04/13/2012 12:43 PM, Scott Wood wrote:
>> On 04/13/2012 01:29 PM, Simon Glass wrote:
>>> Add a NAND controller along with a bindings file for review.
>>>
>>> Signed-off-by: Simon Glass<sjg@chromium.org>
>
>>> +++ b/doc/device-tree-bindings/nand/nvidia-nand.txt
>
>>> +wp-gpio : GPIO of write-protect line, three cells in the format:
>>> + phandle, parameter, flags
>>
>> nvidia,nand-wp-gpio
>
> I'm not convinced about this. For example many SDHCI bindings use just
> "wp-gpios" not "shdci-wp-gpios". Is there really a need to keep the
> property names unique across all bindings, even though a given node only
> relies on one binding?
>
Yeah, there's a lot of bad practice in the existing trees. But the
general recommendation for a while now has been to namespace properties
that aren't defined in standardized, device-indpendent way. That way we
don't get conflicts if we want to use that name for a standard property
in the future, and there's less confusion if multiple people use the
same name in different devices with different semantics.
-Scott
next prev parent reply other threads:[~2012-04-13 21:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 18:29 [U-Boot] [PATCH v2 0/7] tegra: Add NAND flash support Simon Glass
2012-04-13 18:29 ` [U-Boot] [PATCH v2 1/7] nand: Try to align the default buffers Simon Glass
2012-04-13 18:37 ` Scott Wood
2012-04-13 18:52 ` Simon Glass
2012-04-13 19:17 ` Scott Wood
2012-04-13 19:24 ` Simon Glass
2012-04-13 18:29 ` [U-Boot] [PATCH v2 2/7] fdt: Add debugging to fdtdec_get_int/addr() Simon Glass
2012-04-13 18:29 ` [U-Boot] [PATCH v2 3/7] tegra: Add NAND support to funcmux Simon Glass
2012-04-13 18:29 ` [U-Boot] [PATCH v2 4/7] tegra: fdt: Add NAND controller binding and definitions Simon Glass
2012-04-13 18:43 ` Scott Wood
2012-04-13 19:01 ` Simon Glass
2012-04-13 19:07 ` Scott Wood
2012-04-13 19:16 ` Simon Glass
2012-04-13 20:58 ` Stephen Warren
2012-04-13 21:21 ` Scott Wood [this message]
2012-04-13 21:22 ` Stephen Warren
2012-04-13 21:56 ` Scott Wood
2012-04-13 21:05 ` Stephen Warren
2012-04-13 21:12 ` Scott Wood
2012-04-17 18:33 ` Simon Glass
2012-04-17 18:38 ` Scott Wood
2012-04-17 18:44 ` Simon Glass
2012-04-17 18:45 ` Scott Wood
2012-04-17 18:47 ` Simon Glass
2012-04-13 18:29 ` [U-Boot] [PATCH v2 5/7] tegra: fdt: Add NAND definitions to fdt Simon Glass
2012-04-13 18:29 ` [U-Boot] [PATCH v2 6/7] tegra: nand: Add Tegra NAND driver Simon Glass
2012-04-13 18:29 ` [U-Boot] [PATCH v2 7/7] tegra: Enable NAND on Seaboard Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8898E4.4000505@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox