public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qsabresd: Add basic support
Date: Sat, 14 Apr 2012 16:41:41 +0200	[thread overview]
Message-ID: <4F898CA5.8070308@denx.de> (raw)
In-Reply-To: <CAOMZO5DY03d+wm0dV6Y3D8W8RAUeBf6xzord1SgOwmfHqxTLFg@mail.gmail.com>

Am 14/04/2012 01:04, schrieb Fabio Estevam:
> On Fri, Apr 13, 2012 at 7:36 PM, Fabio Estevam <festevam@gmail.com> wrote:
> 

Hi Fabio,

>> So, would it be OK to use 0x10000000 - 0x177fffff as the memory range for mtest?

Some considerations about this issue. hopefully I am not OT. The values
put in the configuration file are the default parameters taken by the
mtest command if no parameters are issued. I agree they must not be set
to wrong values (I mean, outside the adressable RAM), but in any case
mtest is not run automatically and the range can be adjusted in the
console. I can always send a "mtest 0x0x10000000 - 0x177fffff" even if a
restricted range is set in the config file, for example as it is set
now for the mx6qsabrelite (64k).

The start address CONFIG_SYS_MEMTEST_START is the lowest address of the
SDRAM that can be accessed, that is MMDC0_ARB_BASE_ADDR (0x10000000) for
i.MX6.

Now we can take a look at the end address. IMHO it is better to inform
always mtest about which is the end address to be tested, and not rely
to a default value. And, because the total memory is computed
dynamically, also the last RAM address that can be tested should be
computed at run time and not at compile time with CONFIG_SYS_MEMTEST_END.

So I will be for a patch that changes the behavior of mtest and computes
automatically the last testable address if the second parameter is not
given, dropping CONFIG_SYS_MEMTEST_END - I know, this is not part of
your patch, I have already said I can be OT ;-)

Regarding the i.MX6, I think it is not important to bind the last
address to 0x10800000 (CONFIG_LOADADDR). This is only the default
address used to load data. U-Boot is not multitasking, so we are sure
that when mtest runs nothing is loaded, and we can test also this memory
range. Maybe it is more important to test the range from 0x10800000,
because it is used mostly to transfer data and we would like to know if
there is some problem in this range.

The only thing we have to be sure is that we cannot overwrite where
u-boot is currently running and its resorces (malloc area, stack, lcd
memory,..). That is, after the relocation, quite at the end of the
available memory (maybe  gd->relocaddr -1 ?).

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2012-04-14 14:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 15:28 [U-Boot] [PATCH] mx6qsabresd: Add basic support Fabio Estevam
2012-04-11 19:49 ` Wolfgang Denk
2012-04-11 20:15   ` Fabio Estevam
2012-04-11 21:36     ` Wolfgang Denk
2012-04-13 15:56       ` Fabio Estevam
2012-04-13 16:14         ` Dirk Behme
2012-04-13 22:36           ` Fabio Estevam
2012-04-13 23:04             ` Fabio Estevam
2012-04-14  5:36               ` Dirk Behme
2012-04-14 14:41               ` stefano babic [this message]
2012-04-14 15:24                 ` Fabio Estevam
2012-04-14 15:28                   ` Fabio Estevam
2012-04-14 16:00                     ` stefano babic
2012-04-14 20:15                       ` Wolfgang Denk
2012-04-15  8:56                         ` stefano babic
2012-04-14 20:14                   ` Wolfgang Denk
2012-04-14 20:13                 ` Wolfgang Denk
2012-04-15  9:02                   ` stefano babic
2012-07-11  6:23                     ` Dirk Behme
2012-07-11  8:08                       ` Fabio Estevam
2012-04-12  8:23   ` Marek Vasut
2012-04-12 10:52 ` Stefano Babic
2012-09-11  3:56   ` Fabio Estevam
2012-09-11  4:27     ` stefano babic
2012-09-11  5:39     ` Dirk Behme
2012-09-11 14:43     ` Eric Nelson
2012-09-11 15:07       ` Otavio Salvador
2012-09-11 22:10       ` stefano babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F898CA5.8070308@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox