public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chunhe Lan <b25806@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PowerPC: Change -fpic flag to -fPIC flag in the config.mk
Date: Wed, 18 Apr 2012 15:32:22 +0800	[thread overview]
Message-ID: <4F8E6E06.3060101@freescale.com> (raw)
In-Reply-To: <20120418060356.4F9D9200229@gemini.denx.de>



Wolfgang Denk wrote:
> Dear Chunhe Lan,
>
> In message <1334719161-3500-1-git-send-email-Chunhe.Lan@freescale.com> 
> you wrote:
>> The -fPIC/-fpic flag belongs with -mrelocatable. The -fpic flag can
>> limit the size of the GOT and produce smaller binaries, so it causes
>> some GOT entries to be lost in the gcc 4.6 version. But -fPIC flag
>> allows the maximum possible size of the GOT entries.
>>
>> However, currently -mrelocatable promotes -fpic flag to -fPIC flag.
>>
>> This reverts that portion of the
>> commit 33ee4c92339ee386662c0ee2d221098c5cc8b07e.
>
> As you state yourself, your modification has the negative impact of
> increasing the image size. What would be the benefits of it?
>
> Are you trying to fix any specific problem? Which one? I am not aware
> of any related isses for any of the mainline PowerPC systems...
     Yes, I have fixed the booting issue of nand u-boot of 
P1010/P1022/P1023/P2020 with this patch.

    When use gcc 4.5 version, produce the size of u-boot-nand.bin to be 
same with -fpic or -fPIC.
    The u-boot-nand.bin is OK.

    But when use gcc 4.6 version, produce the size of u-boot-nand.bin to 
be different with -fpic or -fPIC.
    The some GOT entries of u-boot-nand.bin are lost with -fpic(because 
limit the size),  so
     u-boot-nand.bin hangs when booting. But use -fPIC, the 
u-boot-nand.bin is OK.

    And this patch reverts that portion of the commit 
33ee4c92339ee386662c0ee2d221098c5cc8b07e.
   
    Thanks,
    Chunhe
>
> Best regards,
>
> Wolfgang Denk
>

  parent reply	other threads:[~2012-04-18  7:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18  3:19 [U-Boot] [PATCH] PowerPC: Change -fpic flag to -fPIC flag in the config.mk Chunhe Lan
2012-04-18  6:03 ` Wolfgang Denk
     [not found]   ` <4F8E5F11.4020904@freescale.com>
2012-04-18  7:11     ` Wolfgang Denk
2012-04-18  7:32   ` Chunhe Lan [this message]
2012-04-18  9:20     ` Wolfgang Denk
2012-04-18 10:07     ` Joakim Tjernlund
2012-04-25 19:01       ` Scott Wood
2012-04-26  6:53         ` Joakim Tjernlund
2012-04-26 21:26           ` Scott Wood
2012-04-27  7:05             ` Joakim Tjernlund
2012-04-27  7:10               ` Joakim Tjernlund
     [not found] <1334717055-16652-1-git-send-email-Chunhe.Lan@freescale.com>
2012-04-18 16:10 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8E6E06.3060101@freescale.com \
    --to=b25806@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox