[U-Boot] [PATCH 7/9] imx: esdhc: Needed to use in imx-regs.h defined address

Stefano Babic
2012-04-18T08:43:56Z

On 18/04/2012 09:57, Timo Ketola wrote:
> One might want to define CONFIG_SYS_FSL_ESDHC_ADDR with the macro already
> define in imx-regs.h, e.g. with IMX_MMC_SDHC1_BASE. Then the header must be
> included here.
>
> Signed-off-by: Timo Ketola <timo@exertus.fi>
> ---
> drivers/mmc/fsl_esdhc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index a2f35e3..5ada747 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -36,6 +36,7 @@
> #include <fsl_esdhc.h>
> #include <fdt_support.h>
> #include <asm/io.h>
> +#include <asm/arch/imx-regs.h>
>

NAK. There is a good reason to avoid it. The fsl_esdhc driver is common
to both i.MX and PowerPc architecture, and of course PowerPC have not
imx-regs.h. And CONFIG_SYS_FSL_ESDHC_ADDR cannot be set by a macro in
imx-regs.h, because it is different on PowerPC.

By the way, why do you need it if you do not use that macro ?

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================