From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timo Ketola <timo@exertus.fi>
Date: Thu, 19 Apr 2012 23:18:29 +0300
Subject: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before
 configuring gasket
In-Reply-To: <4F906714.9030909@boundarydevices.com>
References: <1334223234-23383-1-git-send-email-timo@exertus.fi>
	<1334825735-27992-1-git-send-email-timo@exertus.fi>
	<1334825735-27992-4-git-send-email-timo@exertus.fi>
	<4F906714.9030909@boundarydevices.com>
Message-ID: <4F907315.7050907@exertus.fi>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 19.04.2012 22:27, Troy Kisky wrote:
> On 4/19/2012 1:55 AM, Timo Ketola wrote:
>> -#if !defined(CONFIG_MII)
>> - /* configure gasket for RMII, 50 MHz, no loopback, and no echo */
>> - writew(MIIGSK_CFGR_IF_MODE_RMII,&fec->eth->miigsk_cfgr);
>> +#if defined(CONFIG_RMII)
>
> While this change seems to make sense, it could break some boards.

Please explain how. Every board using fec_mxc define CONFIG_MII - they have to:

#ifndef CONFIG_MII
#error "CONFIG_MII has to be defined!"
#endif

> Please split out to a separate patch, and leave as !defined(CONFIG_MII)
> for this patch.

Stefano?

--

Timo