[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Wolfgang Denk]

Fix: FATAL ERROR: Couldn't open "../arch/arm/dts/tegra20.dtsi": No
such file or directory

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Simon Glass <sjg@chromium.org>
---
 dts/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dts/Makefile b/dts/Makefile
index 5792afd..8b13b23 100644
--- a/dts/Makefile
+++ b/dts/Makefile
@@ -36,7 +36,7 @@ $(error Your architecture does not have device tree support enabled. \
 Please define CONFIG_ARCH_DEVICE_TREE))
 
 # We preprocess the device tree file provide a useful define
-DTS_CPPFLAGS := -DARCH_CPU_DTS=\"../arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\"
+DTS_CPPFLAGS := -DARCH_CPU_DTS=\"$(SRCTREE)/arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\"
 
 all:	$(obj).depend $(LIB)
 
-- 
1.7.7.6

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Simon Glass]

Hi Wolfgang,

On Thu, Apr 19, 2012 at 5:36 AM, Wolfgang Denk <wd@denx.de> wrote:
> Fix: FATAL ERROR: Couldn't open "../arch/arm/dts/tegra20.dtsi": No
> such file or directory

With this problem I have been pursuing include paths in dtc, since
then we don't need CPP. This feature is now in dtc:

de6b762 dtc: Add -i option to support search paths

I have a patch to use that feature, so I will send it to the list.

>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> ?dts/Makefile | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/dts/Makefile b/dts/Makefile
> index 5792afd..8b13b23 100644
> --- a/dts/Makefile
> +++ b/dts/Makefile
> @@ -36,7 +36,7 @@ $(error Your architecture does not have device tree support enabled. \
> ?Please define CONFIG_ARCH_DEVICE_TREE))
>
> ?# We preprocess the device tree file provide a useful define
> -DTS_CPPFLAGS := -DARCH_CPU_DTS=\"../arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\"
> +DTS_CPPFLAGS := -DARCH_CPU_DTS=\"$(SRCTREE)/arch/$(ARCH)/dts/$(CONFIG_ARCH_DEVICE_TREE).dtsi\"
>
> ?all: ? $(obj).depend $(LIB)
>
> --
> 1.7.7.6
>

Regards,
Simon

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Wolfgang Denk]

Dear Simon,

In message <CAPnjgZ2eTmxeeFunjY=3tdwHjb9vjExJ7eWCim5LQEU+O3552w@mail.gmail.com> you wrote:
> 
> With this problem I have been pursuing include paths in dtc, since
> then we don't need CPP. This feature is now in dtc:
> 
> de6b762 dtc: Add -i option to support search paths
> 
> I have a patch to use that feature, so I will send it to the list.

Again, I would like to apply this patch, to fix this problem for the
DTV versions that are currently in use in all the major distributions.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Nobody will ever need more than 640k RAM!"       -- Bill Gates, 1981
"Windows 95 needs at least 8 MB RAM."             -- Bill Gates, 1996
"Nobody will ever need Windows 95."             -- logical conclusion

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Simon Glass]

Hi Wolfgang,

On Thu, Apr 19, 2012 at 11:27 AM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Simon,
>
> In message <CAPnjgZ2eTmxeeFunjY=3tdwHjb9vjExJ7eWCim5LQEU+O3552w@mail.gmail.com> you wrote:
>>
>> With this problem I have been pursuing include paths in dtc, since
>> then we don't need CPP. This feature is now in dtc:
>>
>> de6b762 dtc: Add -i option to support search paths
>>
>> I have a patch to use that feature, so I will send it to the list.
>
> Again, I would like to apply this patch, to fix this problem for the
> DTV versions that are currently in use in all the major distributions.

Fair enough. I hope that doesn't preclude us from using new features
for too long.

Acked-by: Simon Glass <sjg@chromium.org>

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "Nobody will ever need more than 640k RAM!" ? ? ? -- Bill Gates, 1981
> "Windows 95 needs at least 8 MB RAM." ? ? ? ? ? ? -- Bill Gates, 1996
> "Nobody will ever need Windows 95." ? ? ? ? ? ? -- logical conclusion

Regards,
Simon

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Wolfgang Denk]

Dear Simon Glass,

In message <CAPnjgZ2-kzLW2-WdBk2qmezurJBPzT1vAHnxrf7RHZ_Xfw6YbA@mail.gmail.com> you wrote:
> 
> Fair enough. I hope that doesn't preclude us from using new features
> for too long.

Thanks.

Most distributions appear to pick up such changes not too fast, so we
may run into issues here and there.  I think we should decide this on
a case by case base - here it was a trivial change to the existing
code that fixed the problem.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What the gods would destroy they first submit to  an  IEEE  standards
committee.

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Stephen Warren]

On 04/19/2012 12:38 PM, Wolfgang Denk wrote:
> Dear Simon Glass,
> 
> In message <CAPnjgZ2-kzLW2-WdBk2qmezurJBPzT1vAHnxrf7RHZ_Xfw6YbA@mail.gmail.com> you wrote:
>>
>> Fair enough. I hope that doesn't preclude us from using new features
>> for too long.
> 
> Thanks.
> 
> Most distributions appear to pick up such changes not too fast, so we
> may run into issues here and there.  I think we should decide this on
> a case by case base - here it was a trivial change to the existing
> code that fixed the problem.

The kernel deals with this by packaging a copy of dtc (the source) as
part of the kernel source tree. Then, it can upgrade to new features as
soon as they're needed without any distro dependency.

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Simon Glass]

Hi Stephen,

On Thu, Apr 19, 2012 at 2:11 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 04/19/2012 12:38 PM, Wolfgang Denk wrote:
>> Dear Simon Glass,
>>
>> In message <CAPnjgZ2-kzLW2-WdBk2qmezurJBPzT1vAHnxrf7RHZ_Xfw6YbA@mail.gmail.com> you wrote:
>>>
>>> Fair enough. I hope that doesn't preclude us from using new features
>>> for too long.
>>
>> Thanks.
>>
>> Most distributions appear to pick up such changes not too fast, so we
>> may run into issues here and there. ?I think we should decide this on
>> a case by case base - here it was a trivial change to the existing
>> code that fixed the problem.
>
> The kernel deals with this by packaging a copy of dtc (the source) as
> part of the kernel source tree. Then, it can upgrade to new features as
> soon as they're needed without any distro dependency.

Yes, I noticed that.

Another argument is that U-Boot / Linux shouldn't have anything to do
with building device tree files, and therefore the tools are Someone
Else's Problem - the flashing / packaging tools should do it.

I don't really have an opinion on this yet. Given the speed that dtc
moves at, perhaps this is a problem we can live with for now.

Regards,
Simon

[U-Boot] [PATCH] fdt: fix out of tree builds with DT support

[Wolfgang Denk]

Dear Wolfgang Denk,

In message <1334838967-23089-1-git-send-email-wd@denx.de> you wrote:
> Fix: FATAL ERROR: Couldn't open "../arch/arm/dts/tegra20.dtsi": No
> such file or directory
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  dts/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are two ways of constructing a software design. One way  is  to
make  it  so  simple that there are obviously no deficiencies and the
other is to make it so complicated that there are  no  obvious  defi-
ciencies.                             - Charles Anthony Richard Hoare