From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Thu, 19 Apr 2012 14:23:12 -0700 Subject: [U-Boot] [PATCH V4 3/8] imx: fec: Resolve speed before configuring gasket In-Reply-To: <4F907FF1.1030103@boundarydevices.com> References: <1334223234-23383-1-git-send-email-timo@exertus.fi> <1334825735-27992-1-git-send-email-timo@exertus.fi> <1334825735-27992-4-git-send-email-timo@exertus.fi> <4F906714.9030909@boundarydevices.com> <4F907315.7050907@exertus.fi> <4F907FF1.1030103@boundarydevices.com> Message-ID: <4F908240.7040605@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4/19/2012 2:13 PM, Troy Kisky wrote: > On 4/19/2012 1:18 PM, Timo Ketola wrote: >> On 19.04.2012 22:27, Troy Kisky wrote: >>> On 4/19/2012 1:55 AM, Timo Ketola wrote: >>>> -#if !defined(CONFIG_MII) >>>> - /* configure gasket for RMII, 50 MHz, no loopback, and no echo */ >>>> - writew(MIIGSK_CFGR_IF_MODE_RMII,&fec->eth->miigsk_cfgr); >>>> +#if defined(CONFIG_RMII) >>> >>> While this change seems to make sense, it could break some boards. >> >> Please explain how. Every board using fec_mxc define CONFIG_MII - >> they have to: >> >> #ifndef CONFIG_MII >> #error "CONFIG_MII has to be defined!" >> #endif > Does every board that has a gasket define CONFIG_RMII? > > Or are you saying that every board with a gasket is already broken? That should be "Or are you saying that every board using a reduced pin code is alread broken?" > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >