From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 23 Apr 2012 11:55:08 +0200 Subject: [U-Boot] [PATCH] i.MX6: Add ANATOP regulator init In-Reply-To: <1334304028-25575-1-git-send-email-dirk.behme@de.bosch.com> References: <1334304028-25575-1-git-send-email-dirk.behme@de.bosch.com> Message-ID: <4F9526FC.1090600@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13/04/2012 10:00, Dirk Behme wrote: > Init the core regulator voltage to 1.2V. This is required for the correct > functioning of the GPU and when the ARM LDO is set to 1.225V. This is a > workaround to fix some memory clock jitter. > > Note: This should be but can't be done in the DCD. The bootloader > prevents access to the ANATOP registers. > > Signed-off-by: Dirk Behme > CC: Jason Chen > CC: Jason Liu > CC: Ranjani Vaidyanathan > CC: Stefano Babic > CC: Fabio Estevam > --- Hi Dirk, > +static void init_anatop_reg(void) > +{ > + struct anatop_regs *anatop = (struct anatop_regs *)ANATOP_BASE_ADDR; > + int reg = readl(&anatop->reg_core); > + > + /* > + * Increase the VDDSOC to 1.2V > + * Mask out the REG_CORE[22:18] bits (REG2_TRIG) > + * and set them to 1.2V (0.7V + 0x14 * 0.025V) > + */ > + reg = (reg & ~(0x1F << 18)) | (0x14 << 18); Everything clear, but what do you mind to add an accessor to set this voltage ? It is straightforward, and more boards could use it. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================