public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX6: Add ANATOP regulator init
Date: Mon, 23 Apr 2012 12:16:08 +0200	[thread overview]
Message-ID: <4F952BE8.8080807@de.bosch.com> (raw)
In-Reply-To: <4F9526FC.1090600@denx.de>

Hi Stefano,

On 23.04.2012 11:55, Stefano Babic wrote:
> On 13/04/2012 10:00, Dirk Behme wrote:
>> Init the core regulator voltage to 1.2V. This is required for the correct
>> functioning of the GPU and when the ARM LDO is set to 1.225V. This is a
>> workaround to fix some memory clock jitter.
>>
>> Note: This should be but can't be done in the DCD. The bootloader
>>       prevents access to the ANATOP registers.
>>
>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>> CC: Jason Chen <b02280@freescale.com>
>> CC: Jason Liu <r64343@freescale.com>
>> CC: Ranjani Vaidyanathan <ra5478@freescale.com>
>> CC: Stefano Babic <sbabic@denx.de>
>> CC: Fabio Estevam <festevam@gmail.com>
>> ---
> 
> Hi Dirk,
> 
>> +static void init_anatop_reg(void)
>> +{
>> +	struct anatop_regs *anatop = (struct anatop_regs *)ANATOP_BASE_ADDR;
>> +	int reg = readl(&anatop->reg_core);
>> +
>> +	/*
>> +	 * Increase the VDDSOC to 1.2V
>> +	 * Mask out the REG_CORE[22:18] bits (REG2_TRIG)
>> +	 * and set them to 1.2V (0.7V + 0x14 * 0.025V)
>> +	 */
>> +	reg = (reg & ~(0x1F << 18)) | (0x14 << 18);
> 
> Everything clear, but what do you mind to add an accessor to set this
> voltage ? It is straightforward, and more boards could use it.

Sorry, but what do you mean with "add an accessor"? Could you give an 
example?

Best regards

Dirk

  reply	other threads:[~2012-04-23 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13  8:00 [U-Boot] [PATCH] i.MX6: Add ANATOP regulator init Dirk Behme
2012-04-18 10:41 ` Dirk Behme
2012-04-18 11:05 ` Jason Liu
2012-04-23  9:55 ` Stefano Babic
2012-04-23 10:16   ` Dirk Behme [this message]
2012-04-23 10:20   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F952BE8.8080807@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox