From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Mon, 23 Apr 2012 12:20:54 +0200
Subject: [U-Boot] [PATCH] i.MX6: Add ANATOP regulator init
In-Reply-To: <4F9526FC.1090600@denx.de>
References: <1334304028-25575-1-git-send-email-dirk.behme@de.bosch.com>
	<4F9526FC.1090600@denx.de>
Message-ID: <4F952D06.2000203@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 23/04/2012 11:55, Stefano Babic wrote:

> 
>> +static void init_anatop_reg(void)
>> +{
>> +	struct anatop_regs *anatop = (struct anatop_regs *)ANATOP_BASE_ADDR;
>> +	int reg = readl(&anatop->reg_core);
>> +
>> +	/*
>> +	 * Increase the VDDSOC to 1.2V
>> +	 * Mask out the REG_CORE[22:18] bits (REG2_TRIG)
>> +	 * and set them to 1.2V (0.7V + 0x14 * 0.025V)
>> +	 */
>> +	reg = (reg & ~(0x1F << 18)) | (0x14 << 18);
> 
> Everything clear, but what do you mind to add an accessor to set this
> voltage ? It is straightforward, and more boards could use it.

Well, sometimes I am quite obscure, maybe I need more coffeine before
writing my answers ;-)

What I mean is to change the function name to something like
set_vddsoc(mV), and exporting it dropping the static clause.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================