From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Tegra2: Add a useful default boot env
Date: Mon, 23 Apr 2012 11:39:30 -0600 [thread overview]
Message-ID: <4F9593D2.10503@wwwdotorg.org> (raw)
In-Reply-To: <20120423171446.GB31450@bill-the-cat>
On 04/23/2012 11:14 AM, Tom Rini wrote:
> On Mon, Apr 23, 2012 at 09:22:22AM -0700, Tom Warren wrote:
>> Stephen,
>>
>> On Fri, Apr 20, 2012 at 2:40 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> On 04/20/2012 01:50 PM, Tom Warren wrote:
>>>> This set of boot cmds from Stephen Warren provides a simple
>>>> default for booting a linux kernel and DT from mmc (eMMC or
>>>> SD-Card, in that order). Tested on Seaboard w/an SD card.
>>> ...
>>>> diff --git a/include/configs/tegra2-common.h b/include/configs/tegra2-common.h
>>> ...
>>>> ?#define CONFIG_EXTRA_ENV_SETTINGS \
>>> ...
>>>> + ? ? "script=/boot.scr.uimg\0" \
>>>
>>> It might be best to make that just /boot.scr. The reason being that I
>>> looked at the Ubuntu Precise images for OMAP, and they don't have
>>> ".uimg" in the filename, even though they're uImage files. It's probably
>>> best to be consistent with the Ubuntu images given the only other
>>> precedent is what I do locally, which can easily be adjusted.
>>
>> I'll change it to /boot.scr, but do we have any stats on other/more
>> distros and what they use?
>
> Can I suggest that instead of using boot.scr files we just use a text
> file that can be imported to the environment and a command run?
That sounds like a great idea; it avoids a mkimage call and generally
simplifies things. Looking at the code, it's just a list of name=value,
one per line.
TomW, I'd suggest looking at ./include/configs/omap3_beagle.h. In
particular:
a) The load from MMC is only attempted if "mmc rescan" succeeds, rather
than just blasting through the script with lots of failures. The hush
shell might be needed for this; is it enabled on Tegra?
b) See the macros loadbootenv/importbootenv which are the replacement
for boot.scr.
TomR, is there a reason OMAP3 uses FAT for /boot rather than ext2?
Perhaps it's due to the need to load intermediate boot loaders from the
filesystem, and that code needs FAT? On Tegra, we jump straight to
U-Boot from the boot ROM without the need for intermediate filesystem
access, and could make /boot ext2 - do you see any reason not to do this?
next prev parent reply other threads:[~2012-04-23 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 19:50 [U-Boot] [PATCH] arm: Tegra2: Add a useful default boot env Tom Warren
2012-04-20 20:24 ` Allen Martin
2012-04-20 20:46 ` Tom Rini
2012-04-20 21:40 ` Stephen Warren
2012-04-23 16:22 ` Tom Warren
2012-04-23 16:36 ` Stephen Warren
2012-04-23 17:17 ` Tom Rini
2012-04-23 17:14 ` Tom Rini
2012-04-23 17:39 ` Stephen Warren [this message]
2012-04-23 17:47 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9593D2.10503@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox