public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] EXYNOS: draw 32bpp bitmap TIZEN logo
Date: Tue, 24 Apr 2012 11:17:33 +0900	[thread overview]
Message-ID: <4F960D3D.4010703@samsung.com> (raw)
In-Reply-To: <20120423092216.603FF200261@gemini.denx.de>

Dear Wolfgang,

On 23 April 2012 18:22, Wolfgang Denk wrote:

> Dear Donghwa Lee,
> 
> In message <4F94B49E.5020802@samsung.com> you wrote:
>> This patches support drawing 32bpp bitmap TIZEN logo in exynos fb.
>> asm/arch/trats_logo.h data is compressed by zip and decomressed at 
>> the exynos fb driver.
>>
>> And vl_bpix of vidinfo_t is changed proper value for u-boot.
>>
>> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
>> Signed-off-by: Kyungmin park <kyungmin.park@samsung.com>
>> ---
>>  arch/arm/include/asm/arch-exynos/trats_logo.h | 5070 +++++++++++++++++++++++++
>>  board/samsung/trats/trats.c                   |    2 +-
>>  drivers/video/exynos_fb.c                     |   40 +-
>>  drivers/video/exynos_fimd.c                   |    6 +-
>>  include/configs/trats.h                       |    4 +-
>>  5 files changed, 5116 insertions(+), 6 deletions(-)
>>  create mode 100644 arch/arm/include/asm/arch-exynos/trats_logo.h
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/trats_logo.h b/arch/arm/include/asm/arch-exynos/trats_logo.h
>> new file mode 100644
>> index 0000000..a595abd
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-exynos/trats_logo.h
> 
> This is not a good location for the logo data.  Either this is vendor
> specific, in which place it should go to the vendor directory, or it's
> board specific, in which case it should go into the board directory.
> 
> In no case I want to have this in arch/arm/include/
> 
> thanks.
> 
> Best regards,
> 
> Wolfgang Denk
> 

Thank you for your comment.
This logo data is TIZEN logo for TRATS board.
Current TIZEN reference board is TRATS based on EXYNOS SoC.
But, I don'know exactly any others boards that loaded TIZEN based on
others SoC will be appeared in the future.

So, I think this logo data is not board(TRATS) and vendor(EXYNOS) 
specific. So, I want to move this data in include/

How do you think about that? 
Plese tell me your opinions.

Thank you,
Donghwa Lee

  reply	other threads:[~2012-04-24  2:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  1:47 [U-Boot] [PATCH 2/2] EXYNOS: draw 32bpp bitmap TIZEN logo Donghwa Lee
2012-04-23  9:00 ` Minkyu Kang
2012-04-23 10:16   ` Donghwa Lee
2012-04-23 10:56     ` Minkyu Kang
2012-04-23  9:22 ` Wolfgang Denk
2012-04-24  2:17   ` Donghwa Lee [this message]
2012-04-24 15:39 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F960D3D.4010703@samsung.com \
    --to=dh09.lee@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox