From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4][v3] powerpc/85xx:Make debug exception vector accessible
Date: Tue, 24 Apr 2012 16:10:42 -0500 [thread overview]
Message-ID: <4F9716D2.1030109@freescale.com> (raw)
In-Reply-To: <CAKWjMd6u+mF1Ejtg-0_yUgQoxr7MbOg4yd2W8sy+3yWy=i3rnw@mail.gmail.com>
On 04/24/2012 03:45 PM, Andy Fleming wrote:
> On Mon, Mar 26, 2012 at 4:00 AM, Prabhakar Kushwaha
>> @@ -107,6 +107,7 @@
>> #define CONFIG_MAX_CPUS 1
>> #define CONFIG_FSL_SDHC_V2_3
>> #define CONFIG_SYS_FSL_NUM_LAWS 12
>> +#define CONFIG_SYS_PPC_E500_DEBUG_TLB 3
>
>
> You've only enabled this for one processor. Maybe the P1010. Nowhere
> in the patch description does it mention that this is only being
> enabled for one chip. As it is, I think you meant to enable it for
> more chips, and I'm wondering why it's not enabled for the other chips
> mentioned in the comments above as being test platforms for this
> patch...
>
> Probably, for this feature, we should make a default definition, which
> can be overridden by other parts if necessary.
>
> In other words, add something like this near the end:
>
> #ifndef CONFIG_SYS_PPC_E500_DEBUG_TLB
> #define CONFIG_SYS_PPC_E500_DEBUG_TLB 3
> #endif
We don't want to enable this on e500mc (testing in that context just
means that we didn't break the code path where this isn't enabled). I'm
not sure whether it will break anything if we do enable it on e500mc,
but we don't need it.
-Scot
next prev parent reply other threads:[~2012-04-24 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 9:00 [U-Boot] [PATCH 3/4][v3] powerpc/85xx:Make debug exception vector accessible Prabhakar Kushwaha
2012-04-24 20:45 ` Andy Fleming
2012-04-24 21:10 ` Scott Wood [this message]
2012-04-24 21:20 ` Andy Fleming
2012-04-25 3:48 ` Prabhakar Kushwaha
2012-04-25 4:05 ` Andy Fleming
2012-04-25 14:50 ` Scott Wood
2012-04-26 3:24 ` Prabhakar Kushwaha
[not found] ` <CAKWjMd4hHeUBMGHKAVJn55T5HjE-dxE4Ss1s+1wZVuSTzV_rDA@mail.gmail.com>
2012-04-27 0:23 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9716D2.1030109@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox