From: Timo Ketola <timo@exertus.fi>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX2: Support splash screen
Date: Thu, 26 Apr 2012 17:37:31 +0300 [thread overview]
Message-ID: <4F995DAB.4070802@exertus.fi> (raw)
In-Reply-To: <20120426135102.146cb257@wker>
Dear Anatolij,
Thanks for the review. Everything else is clear, but...
On 26.04.2012 14:51, Anatolij Gustschin wrote:
...
>> +++ b/drivers/video/mx2fb.c
>> @@ -0,0 +1,92 @@
>
> Please add Copyright info here.
...
>> +++ b/include/mx2fb.h
...
> Please consider Stefano's comment regarding copyright header.
I'm a little lost here. The original work is this:
http://www.imxdev.org/wiki/images/d/d0/U-boot-splash.tar.gz
from here:
http://www.imxdev.org/wiki/index.php?title=I.MX25_PDK_U-boot_SplashScreen
There is also a u-boot.spec.in file in the package which says:
License : GPL
Vendor : Freescale
Packager : MAD
Now, can I really just edit the mx2fb.h copyright notice to say "V2 or
later" and copy it into the mx2fb.h? If I do that, add the imxdev.org
links into the commit message and tersely say there how I changed the
source (left out 24bpp and splash_is_in_mmc support), would that be good
enough?
--
Timo
next prev parent reply other threads:[~2012-04-26 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 8:54 [U-Boot] [PATCH 0/1] i.MX2: Support splash screen Timo Ketola
2012-04-18 8:54 ` [U-Boot] [PATCH] " Timo Ketola
2012-04-18 9:26 ` Wolfgang Denk
2012-04-18 10:47 ` Stefano Babic
2012-04-20 11:01 ` [U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation Timo Ketola
2012-04-20 11:01 ` [U-Boot] [PATCH] i.MX25: lcdc: Add register definitions Timo Ketola
2012-04-26 11:53 ` Anatolij Gustschin
2012-04-26 9:57 ` [U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation Anatolij Gustschin
2012-04-26 11:18 ` Timo Ketola
2012-04-26 12:01 ` Anatolij Gustschin
2012-04-26 11:51 ` [U-Boot] [PATCH] i.MX2: Support splash screen Anatolij Gustschin
2012-04-26 14:37 ` Timo Ketola [this message]
2012-04-26 15:30 ` Anatolij Gustschin
2012-04-18 9:26 ` [U-Boot] [PATCH 0/1] " Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F995DAB.4070802@exertus.fi \
--to=timo@exertus.fi \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox