From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 27 Apr 2012 10:31:02 -0700 Subject: [U-Boot] [PATCH v2 1/2] CONFIG_SYS_BAUDRATE_TABLE: Add , place there In-Reply-To: <20120427171925.EAEC120627D@gemini.denx.de> References: <1335480396-29478-1-git-send-email-trini@ti.com> <20120427063137.077F6200244@gemini.denx.de> <4F9AB2EE.3070202@ti.com> <20120427161749.9E092200244@gemini.denx.de> <4F9ACDB8.8000705@ti.com> <20120427171925.EAEC120627D@gemini.denx.de> Message-ID: <4F9AD7D6.4050202@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/27/2012 10:19 AM, Wolfgang Denk wrote: > Dear Tom, > > In message<4F9ACDB8.8000705@ti.com> you wrote: >> >>>> Then we're really SOL here. Even if we limit it to "I dropped >>>> 300/600/900/1200/2400/4800 baud rate support, is that ok". >>> >>> What's wrong with keeping a customizes #define for the boards that use >>> nonstandard settings? >> >> As I said in the commit message, I believe it was done for completeness >> rather than need, but if you like I can change it to just delete > > As long as we don't know it exactly and for sure, we should not change > the configuration of boards that don't belong to us (unless the changes > are obviously harmless or clear bug fixes). Alright, I'll drop those boards then. >> 4800/9600/19200/38400/115200 (and reversed) and leave the rest alone. >> And then I'll drop it from the boards I own :) > > OK. > >>> But you see the problem in the patch, don't you? >> >> With it not applying? No... > > Well, your patch reads for example: > > diff --git a/include/configs/AP1000.h b/include/configs/AP1000.h > index b598371..fd074fb 100644 > --- a/include/configs/AP1000.h > +++ b/include/configs/AP1000.h > @@ -142,7 +142,6 @@ > #define CONFIG_SYS_INIT_CHAN2 0 > > /* The following table includes the supported baudrates */ > -#undef CONFIG_SYS_BAUDRATE_TABLE > #define CONFIG_SYS_BAUDRATE_TABLE \ > {300, 600, 1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200, 230400} guh.. I'll go kick git some then. -- Tom